Code review comment for lp:~intrigeri/apparmor/nameservice-NetworkManager

Revision history for this message
intrigeri (intrigeri) wrote :

Seth Arnold wrote (10 Feb 2016 18:14:11 GMT) :
> Two alternations in one rule with mutli-path segments in both of them makes this
> quite difficult for me to read. It grants access to six files and it's not clear to
> me that all six are actually necessary somewhere.

> There's more text in the comments explaining it than is actually needed to refer to the files individually. :)

I'll keep this in mind. Thanks for reviewing :)

> If this is already merged, than it's probably not worth any more time, but if this isn't yet merged, I'd like to see it split apart.

Apparently it's merged already.

« Back to merge proposal