Code review comment for lp:~intrigeri/apparmor/nameservice-NetworkManager

Revision history for this message
Seth Arnold (seth-arnold) wrote :

Two alternations in one rule with mutli-path segments in both of them makes this quite difficult for me to read. It grants access to six files and it's not clear to me that all six are actually necessary somewhere.

There's more text in the comments explaining it than is actually needed to refer to the files individually. :)

If this is already merged, than it's probably not worth any more time, but if this isn't yet merged, I'd like to see it split apart.

Thanks

« Back to merge proposal