Merge lp:~intellectronica/launchpad/bug-supervisor-no-redirect into lp:launchpad

Proposed by Eleanor Berger
Status: Merged
Approved by: Graham Binns
Approved revision: no longer in the source branch.
Merged at revision: not available
Proposed branch: lp:~intellectronica/launchpad/bug-supervisor-no-redirect
Merge into: lp:launchpad
Diff against target: None lines
To merge this branch: bzr merge lp:~intellectronica/launchpad/bug-supervisor-no-redirect
Reviewer Review Type Date Requested Status
Graham Binns (community) code Approve
Brad Crittenden (community) release-critical Approve
Review via email: mp+12269@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Eleanor Berger (intellectronica) wrote :

This branch disables to Ubuntu +filebug redirect for Ubuntu's bug supervisor, as per requests by the project development team

Revision history for this message
Brad Crittenden (bac) :
review: Approve (release-critical)
Revision history for this message
Graham Binns (gmb) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/lp/bugs/browser/bugtarget.py'
--- lib/lp/bugs/browser/bugtarget.py 2009-09-22 15:14:14 +0000
+++ lib/lp/bugs/browser/bugtarget.py 2009-09-23 10:08:05 +0000
@@ -351,7 +351,8 @@
351 return (351 return (
352 self.request.form.get('no-redirect') is not None or352 self.request.form.get('no-redirect') is not None or
353 [key for key in self.request.form.keys()353 [key for key in self.request.form.keys()
354 if 'field.actions' in key] != [])354 if 'field.actions' in key] != [] or
355 self.user.inTeam(self.context.bug_supervisor))
355356
356 def getPackageNameFieldCSSClass(self):357 def getPackageNameFieldCSSClass(self):
357 """Return the CSS class for the packagename field."""358 """Return the CSS class for the packagename field."""
358359
=== modified file 'lib/lp/bugs/stories/guided-filebug/xx-ubuntu-filebug.txt'
--- lib/lp/bugs/stories/guided-filebug/xx-ubuntu-filebug.txt 2009-09-22 16:31:43 +0000
+++ lib/lp/bugs/stories/guided-filebug/xx-ubuntu-filebug.txt 2009-09-23 10:08:05 +0000
@@ -42,6 +42,20 @@
42 >>> print user_browser.url42 >>> print user_browser.url
43 http://bugs.launchpad.dev/ubuntu/+source/pmount/+filebug?no-redirect43 http://bugs.launchpad.dev/ubuntu/+source/pmount/+filebug?no-redirect
4444
45Ubuntu's bug supervisor doesn't get automatically redirected either.
46
47 >>> from zope.component import getUtility
48 >>> from canonical.launchpad.interfaces import IDistributionSet, IPersonSet
49 >>> login('foo.bar@canonical.com')
50 >>> ubuntu = getUtility(IDistributionSet).getByName('ubuntu')
51 >>> foobar = getUtility(IPersonSet).getByName('name16')
52 >>> ubuntu.setBugSupervisor(foobar, foobar)
53 >>> transaction.commit()
54 >>> logout()
55
56 >>> admin_browser.open('http://bugs.launchpad.dev/ubuntu/+filebug')
57 >>> print admin_browser.title
58 Report a bug about Ubuntu...
4559
46Filing bugs with Apport also allows us to get to the bug filing interface.60Filing bugs with Apport also allows us to get to the bug filing interface.
4761