Merge lp:~intellectronica/launchpad/bug-supervisor-no-redirect into lp:launchpad

Proposed by Eleanor Berger
Status: Merged
Approved by: Graham Binns
Approved revision: no longer in the source branch.
Merged at revision: not available
Proposed branch: lp:~intellectronica/launchpad/bug-supervisor-no-redirect
Merge into: lp:launchpad
Diff against target: None lines
To merge this branch: bzr merge lp:~intellectronica/launchpad/bug-supervisor-no-redirect
Reviewer Review Type Date Requested Status
Graham Binns (community) code Approve
Brad Crittenden (community) release-critical Approve
Review via email: mp+12269@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Eleanor Berger (intellectronica) wrote :

This branch disables to Ubuntu +filebug redirect for Ubuntu's bug supervisor, as per requests by the project development team

Revision history for this message
Brad Crittenden (bac) :
review: Approve (release-critical)
Revision history for this message
Graham Binns (gmb) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/bugs/browser/bugtarget.py'
2--- lib/lp/bugs/browser/bugtarget.py 2009-09-22 15:14:14 +0000
3+++ lib/lp/bugs/browser/bugtarget.py 2009-09-23 10:08:05 +0000
4@@ -351,7 +351,8 @@
5 return (
6 self.request.form.get('no-redirect') is not None or
7 [key for key in self.request.form.keys()
8- if 'field.actions' in key] != [])
9+ if 'field.actions' in key] != [] or
10+ self.user.inTeam(self.context.bug_supervisor))
11
12 def getPackageNameFieldCSSClass(self):
13 """Return the CSS class for the packagename field."""
14
15=== modified file 'lib/lp/bugs/stories/guided-filebug/xx-ubuntu-filebug.txt'
16--- lib/lp/bugs/stories/guided-filebug/xx-ubuntu-filebug.txt 2009-09-22 16:31:43 +0000
17+++ lib/lp/bugs/stories/guided-filebug/xx-ubuntu-filebug.txt 2009-09-23 10:08:05 +0000
18@@ -42,6 +42,20 @@
19 >>> print user_browser.url
20 http://bugs.launchpad.dev/ubuntu/+source/pmount/+filebug?no-redirect
21
22+Ubuntu's bug supervisor doesn't get automatically redirected either.
23+
24+ >>> from zope.component import getUtility
25+ >>> from canonical.launchpad.interfaces import IDistributionSet, IPersonSet
26+ >>> login('foo.bar@canonical.com')
27+ >>> ubuntu = getUtility(IDistributionSet).getByName('ubuntu')
28+ >>> foobar = getUtility(IPersonSet).getByName('name16')
29+ >>> ubuntu.setBugSupervisor(foobar, foobar)
30+ >>> transaction.commit()
31+ >>> logout()
32+
33+ >>> admin_browser.open('http://bugs.launchpad.dev/ubuntu/+filebug')
34+ >>> print admin_browser.title
35+ Report a bug about Ubuntu...
36
37 Filing bugs with Apport also allows us to get to the bug filing interface.
38