Merge lp:~intellectronica/launchpad/bug-531963 into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Eleanor Berger |
Approved revision: | no longer in the source branch. |
Merged at revision: | not available |
Proposed branch: | lp:~intellectronica/launchpad/bug-531963 |
Merge into: | lp:launchpad |
Diff against target: |
193 lines (+148/-3) 3 files modified
lib/canonical/launchpad/javascript/bugs/bugtask-index.js (+78/-3) lib/lp/bugs/browser/bugtask.py (+1/-0) lib/lp/bugs/windmill/tests/test_bug_status.py (+69/-0) |
To merge this branch: | bzr merge lp:~intellectronica/launchpad/bug-531963 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michael Nelson (community) | ui | Approve | |
Abel Deuring (community) | code | Approve | |
Review via email: mp+21628@code.launchpad.net |
Commit message
When changing bug status, require confirmation from users who are not in the project team.
Description of the change
This branch adds a confirmation step when a user who has no privileges in a project tries to edit the bug status. It does that by creating a specialised version of the ChoiceEdit widget that displays a javascript confirm dialog before saving if a new parameter is set. The only gotcha here is the use of confirmAnswer in the windmill test. This is how we simulate confirming (or cancelling). Windmill overrides all calls to modal dialogs in order to avoid blocking execution and uses the value in confirmAnswer instead. This value can't be set from python directly, so we use execJS to inject into the JS environment.
Hi Tom,
the code is fine, but "make lint" has a few complaints. Could you fix them?