Code review comment for lp:~inkscape.dev/inkscape/pathVectorSatellites

Revision history for this message
Krzysztof Kosinski (tweenk) wrote :

This looks better, but I think I understand what Pathinfo does now, and the whole class is unnecessary. The number of nodes in a Geom::Path is equal to size_closed(), you don't need to reimplement it and you don't need the active attribute in satellites.

I only reviewed a portion of the code - I will try to continue the review during this weekend.

review: Needs Fixing

« Back to merge proposal