Code review comment for lp:~inkscape.dev/inkscape/lastApplied

Revision history for this message
Krzysztof Kosinski (tweenk) wrote :

The new behavior looks a lot better, but there are 2 more things to fix:

1. The static global variable 'pathv' is declared in the header, which is unacceptable - it should be declared in the cpp file, preferably in the function itself.
2. The name should be "Last applied".
3. Other cases in the switch should also set 'pathv' to the stroke shape which they applied.

review: Needs Fixing

« Back to merge proposal