Code review comment for lp:~inkscape.dev/inkscape/fillet-chamfer

Revision history for this message
njh (njh-njhurst) wrote :

> One question im on the tree of the class and have a question.
> How many "SPoints" "have a node", think 2 are enougth but maybe is beter make
> it flexible inside a vector.

What are SPoints? how do you maintain the relationship between them and the curve? Keeping things in sorted order makes merging much easier (like you already have).

The two obvious ways to me are a) have a 1:1 mapping between curve nodes and these SPoints (that's a fairly poor name btw, it doesn't mean anything to me at all). b) include the corresponding node index in the SPoint.

« Back to merge proposal