Code review comment for lp:~initos.com/partner-contact-management/7.0

Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

> Yes, apparently my use case is for commercial partners, and your use
> case is for partners marked as customer/suppliers. I must admit that my
> use case is probably incomplete without some additional customization,
> such as adding 'ref' to the fields that are copied to the non-commercial
> contacts (and making it readonly on these contacts). Maybe this scenario
> could be implemented in a separate module. I'll leave this point for now
> then.

OK, I understand you, and yes, I think it's also important to get propagated the reference across children partners to mimic the current logic on partner structure. Maybe we should implement this together in this module to get a definitive module for v7.

> What I was suggesting was that that such a partner gets a reference as
> long as you do not assign a parent company, as per my commercial partner
> use case.

So you are proposing to remove is_customer/is_supplier check?

Regards.

« Back to merge proposal