Code review comment for lp:~initos.com/partner-contact-management/7.0
Revision history for this message
| Stefan Rijnhart (Opener) (stefan-opener) wrote | # |
review:
Needs Fixing
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
Hi Thomas, thanks!
l.176 The get() method of ir.sequence is deprecated. I think 'next_by_code' should be used instead.
l.58 You claim authorship of the module, but I think 'Tiny' was the author. Maybe share the credits like you share the copyright?
l.195 I'm wondering if the condition should be in line with commercial partnership, i.e. maybe partners should qualify if there is no parent, or if the partner has is_company set (instead of being a supplier or a customer). What do think, Thomas and Pedro?