Code review comment for lp:~initos.com/openerp-hr/7.0-change-public-holiday

Hi Nikolina, Markus.

I did not make any tests, but that raised a few questions:

- Now we have those new fields, how will that behave will modules that depend on this one, like hr_holidays_extension from this same branch? For example, if those fields exist, one could expect them to be taken into account for the employee's schedule.

- How should national holidays be entered? No states or all of them?

- Without migration scripts, updating the module leaves country and states empty. Is that the intended behaviour?

Thanks!