Code review comment for lp:~initos.com/openerp-connector-magento/7.0-magentoerpconnect_options_active

Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

Hi Markus,

Thanks for your contribution!

Adding options for that could be interesting indeed, maybe even in the core module.

From a technical point of view, the problem with the 'replacing' here is that it replaces the entire mapper product.ProductImportMapper, so if 2 modules replace the same mapper, there will be a conflict.

The workaround is to introduce a empty / default mapper only for the mapping 'is_active' in the core module and 'replace' only this mapper (and the main ProductImportMapper calls this 'is_active' mapper)

review: Needs Fixing (code review)

« Back to merge proposal