Code review comment for lp:~initos.com/account-invoice-report/7.0-fix_lang_for_draft

Revision history for this message
Katja Matthes (katja-matthes) wrote :

Hi Pedro,

thanks for reviewing.

Well I debug this and actually inv_id is a list. It would be better to rename it to inv_ids. I can add this, if it's wished.

I think you don't understand the issue in detail. The problem occure, when creating an invoice. At this point there's no invoice id, cause the object isn't stored yet. To get the customer's language at this point the only solution I see is to modify the on_change method like the way I did.

If I'm missing something fundamental, please let me know.

Greetings,
Katja

« Back to merge proposal