Code review comment for lp:~info-martin-konrad/epics-gateway/putlog

Revision history for this message
Martin Konrad (info-martin-konrad) wrote :

Hi Ben,
> Looking at
>I have the feeling what the page shows me is not the whole change.
> For instance, I am not seeing any caPutLog includes being added.
Have a look at lines 36 to 39.

> Or maybe I see only the latest change on the branch and not the whole
> diff? How can I see that?
Nope, there are 3 commits on this branch. One adds the new code and two
fix minor issues (I pushed them an hour ago). The merge view shows the
changes introduced by all three commits.

> Sorry for my stupidity w.r.t. lp UI
Sorry, cannot comment on that. LP is not for me either...


Martin Konrad
Control System Engineer
Facility for Rare Isotope Beams
Michigan State University
640 South Shaw Lane
East Lansing, MI 48824-1321, USA
Tel. 517-908-7253
Email: <email address hidden>

« Back to merge proposal