Code review comment for ~info-martin-konrad/epics-base:fix-logserver-file-limit

Revision history for this message
mdavidsaver (mdavidsaver) wrote :

This change looks like it does what is intended.

I assume the goal here is to use an external tool like logrotate to bound file size?

> I was considering proposing that we unbundle the IOC log server completely

+1

If we keep it, I think it is reasonable to retain the ability to log to stderr (or better stdout) as this would mesh well with systemd daemon logging.

review: Approve

« Back to merge proposal