Code review comment for ~ines-almeida/launchpad:fetch-service-add-missing-fetch-service-args
Revision history for this message
| Jürgen Gmach (jugmac00) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
It looks like that as a minimum we need to add the new arg to the `BuildArgs` class in buildfarmjobbeh
Additionally, I would love to see an additional or updated test related to this code change.
Also, how did you notice the missing arg? This might be valuable information to avoid similar issues in the future, as we need to add new build types in the next cycle.