Merge lp:~indicator-applet-developers/ubuntu/precise/indicator-datetime/upstream into lp:~ubuntu-desktop/indicator-datetime/ubuntu
- Precise (12.04)
- upstream
- Merge into ubuntu
Proposed by
Charles Kerr
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ken VanDine | Pending | ||
Review via email: mp+98680@code.launchpad.net |
Commit message
Description of the change
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1 | === modified file 'ChangeLog' | |||
2 | --- ChangeLog 2012-03-08 22:57:20 +0000 | |||
3 | +++ ChangeLog 2012-03-21 16:52:25 +0000 | |||
4 | @@ -1,5 +1,57 @@ | |||
5 | 1 | # Generated by Makefile. Do not edit. | 1 | # Generated by Makefile. Do not edit. |
6 | 2 | 2 | ||
7 | 3 | 2012-03-21 Charles Kerr <charles.kerr@canonical.com> | ||
8 | 4 | |||
9 | 5 | 0.3.92 | ||
10 | 6 | |||
11 | 7 | 2012-03-20 Charles Kerr <charles.kerr@canonical.com> | ||
12 | 8 | |||
13 | 9 | merge lp:~charlesk/indicator-datetime/lp-772340 to fix some memory leaks related to appointments in indicator-datetime | ||
14 | 10 | |||
15 | 11 | 2012-03-18 Charles Kerr <charles.kerr@canonical.com> | ||
16 | 12 | |||
17 | 13 | leak: fix ESourceList leak in update_appointment_menu_items() | ||
18 | 14 | |||
19 | 15 | 2012-03-18 Charles Kerr <charles.kerr@canonical.com> | ||
20 | 16 | |||
21 | 17 | leak: fix GdkPixbuf leak when setting up appointments | ||
22 | 18 | |||
23 | 19 | 2012-03-18 Charles Kerr <charles.kerr@canonical.com> | ||
24 | 20 | |||
25 | 21 | minor: fix inefficient GSList walking -- only walk a GSList once instead of twice per node | ||
26 | 22 | |||
27 | 23 | 2012-03-18 Charles Kerr <charles.kerr@canonical.com> | ||
28 | 24 | |||
29 | 25 | leak: fix the comp_instance struct leaks allocated in populate_appointment_instances() from update_appointment_menu_items(). The list was freed, but not the structs pointed to by the list. | ||
30 | 26 | |||
31 | 27 | 2012-03-18 Charles Kerr <charles.kerr@canonical.com> | ||
32 | 28 | |||
33 | 29 | don't subtract one time_t from another | ||
34 | 30 | |||
35 | 31 | 2012-03-18 Charles Kerr <charles.kerr@canonical.com> | ||
36 | 32 | |||
37 | 33 | leak: plug leaks related to use of gconf_client_get_list() | ||
38 | 34 | |||
39 | 35 | 2012-03-18 Charles Kerr <charles.kerr@canonical.com> | ||
40 | 36 | |||
41 | 37 | minor: use g_clear_error() instead of g_error_free() | ||
42 | 38 | |||
43 | 39 | 2012-03-18 Charles Kerr <charles.kerr@canonical.com> | ||
44 | 40 | |||
45 | 41 | leak: fix GError leaks | ||
46 | 42 | |||
47 | 43 | 2012-03-16 Charles Kerr <charles.kerr@canonical.com> | ||
48 | 44 | |||
49 | 45 | plug a string leak when updating the appointments | ||
50 | 46 | |||
51 | 47 | 2012-03-16 Charles Kerr <charles.kerr@canonical.com> | ||
52 | 48 | |||
53 | 49 | minor: remove unnecessary nesting | ||
54 | 50 | |||
55 | 51 | 2012-03-16 Charles Kerr <charles.kerr@canonical.com> | ||
56 | 52 | |||
57 | 53 | plug a string leak when updating appointments | ||
58 | 54 | |||
59 | 3 | 2012-03-08 Ted Gould <ted@gould.cx> | 55 | 2012-03-08 Ted Gould <ted@gould.cx> |
60 | 4 | 56 | ||
61 | 5 | 0.3.91 | 57 | 0.3.91 |
62 | 6 | 58 | ||
63 | === modified file 'configure' | |||
64 | --- configure 2012-03-08 22:57:20 +0000 | |||
65 | +++ configure 2012-03-21 16:52:25 +0000 | |||
66 | @@ -1,6 +1,6 @@ | |||
67 | 1 | #! /bin/sh | 1 | #! /bin/sh |
68 | 2 | # Guess values for system-dependent variables and create Makefiles. | 2 | # Guess values for system-dependent variables and create Makefiles. |
70 | 3 | # Generated by GNU Autoconf 2.68 for indicator-datetime 0.3.91. | 3 | # Generated by GNU Autoconf 2.68 for indicator-datetime 0.3.92. |
71 | 4 | # | 4 | # |
72 | 5 | # Report bugs to <http://bugs.launchpad.net/indicator-datetime>. | 5 | # Report bugs to <http://bugs.launchpad.net/indicator-datetime>. |
73 | 6 | # | 6 | # |
74 | @@ -572,8 +572,8 @@ | |||
75 | 572 | # Identity of this package. | 572 | # Identity of this package. |
76 | 573 | PACKAGE_NAME='indicator-datetime' | 573 | PACKAGE_NAME='indicator-datetime' |
77 | 574 | PACKAGE_TARNAME='indicator-datetime' | 574 | PACKAGE_TARNAME='indicator-datetime' |
80 | 575 | PACKAGE_VERSION='0.3.91' | 575 | PACKAGE_VERSION='0.3.92' |
81 | 576 | PACKAGE_STRING='indicator-datetime 0.3.91' | 576 | PACKAGE_STRING='indicator-datetime 0.3.92' |
82 | 577 | PACKAGE_BUGREPORT='http://bugs.launchpad.net/indicator-datetime' | 577 | PACKAGE_BUGREPORT='http://bugs.launchpad.net/indicator-datetime' |
83 | 578 | PACKAGE_URL='http://launchpad.net/indicator-datetime' | 578 | PACKAGE_URL='http://launchpad.net/indicator-datetime' |
84 | 579 | 579 | ||
85 | @@ -1395,7 +1395,7 @@ | |||
86 | 1395 | # Omit some internal or obsolete options to make the list less imposing. | 1395 | # Omit some internal or obsolete options to make the list less imposing. |
87 | 1396 | # This message is too long to be a string in the A/UX 3.1 sh. | 1396 | # This message is too long to be a string in the A/UX 3.1 sh. |
88 | 1397 | cat <<_ACEOF | 1397 | cat <<_ACEOF |
90 | 1398 | \`configure' configures indicator-datetime 0.3.91 to adapt to many kinds of systems. | 1398 | \`configure' configures indicator-datetime 0.3.92 to adapt to many kinds of systems. |
91 | 1399 | 1399 | ||
92 | 1400 | Usage: $0 [OPTION]... [VAR=VALUE]... | 1400 | Usage: $0 [OPTION]... [VAR=VALUE]... |
93 | 1401 | 1401 | ||
94 | @@ -1466,7 +1466,7 @@ | |||
95 | 1466 | 1466 | ||
96 | 1467 | if test -n "$ac_init_help"; then | 1467 | if test -n "$ac_init_help"; then |
97 | 1468 | case $ac_init_help in | 1468 | case $ac_init_help in |
99 | 1469 | short | recursive ) echo "Configuration of indicator-datetime 0.3.91:";; | 1469 | short | recursive ) echo "Configuration of indicator-datetime 0.3.92:";; |
100 | 1470 | esac | 1470 | esac |
101 | 1471 | cat <<\_ACEOF | 1471 | cat <<\_ACEOF |
102 | 1472 | 1472 | ||
103 | @@ -1600,7 +1600,7 @@ | |||
104 | 1600 | test -n "$ac_init_help" && exit $ac_status | 1600 | test -n "$ac_init_help" && exit $ac_status |
105 | 1601 | if $ac_init_version; then | 1601 | if $ac_init_version; then |
106 | 1602 | cat <<\_ACEOF | 1602 | cat <<\_ACEOF |
108 | 1603 | indicator-datetime configure 0.3.91 | 1603 | indicator-datetime configure 0.3.92 |
109 | 1604 | generated by GNU Autoconf 2.68 | 1604 | generated by GNU Autoconf 2.68 |
110 | 1605 | 1605 | ||
111 | 1606 | Copyright (C) 2010 Free Software Foundation, Inc. | 1606 | Copyright (C) 2010 Free Software Foundation, Inc. |
112 | @@ -1971,7 +1971,7 @@ | |||
113 | 1971 | This file contains any messages produced by compilers while | 1971 | This file contains any messages produced by compilers while |
114 | 1972 | running configure, to aid debugging if configure makes a mistake. | 1972 | running configure, to aid debugging if configure makes a mistake. |
115 | 1973 | 1973 | ||
117 | 1974 | It was created by indicator-datetime $as_me 0.3.91, which was | 1974 | It was created by indicator-datetime $as_me 0.3.92, which was |
118 | 1975 | generated by GNU Autoconf 2.68. Invocation command line was | 1975 | generated by GNU Autoconf 2.68. Invocation command line was |
119 | 1976 | 1976 | ||
120 | 1977 | $ $0 $@ | 1977 | $ $0 $@ |
121 | @@ -2795,7 +2795,7 @@ | |||
122 | 2795 | 2795 | ||
123 | 2796 | # Define the identity of the package. | 2796 | # Define the identity of the package. |
124 | 2797 | PACKAGE='indicator-datetime' | 2797 | PACKAGE='indicator-datetime' |
126 | 2798 | VERSION='0.3.91' | 2798 | VERSION='0.3.92' |
127 | 2799 | 2799 | ||
128 | 2800 | 2800 | ||
129 | 2801 | cat >>confdefs.h <<_ACEOF | 2801 | cat >>confdefs.h <<_ACEOF |
130 | @@ -13205,14 +13205,12 @@ | |||
131 | 13205 | ;; | 13205 | ;; |
132 | 13206 | esac | 13206 | esac |
133 | 13207 | 13207 | ||
134 | 13208 | INTLTOOL_REQUIRED_VERSION_AS_INT=`echo 0.41.0 | awk -F. '{ print $ 1 * 1000 + $ 2 * 100 + $ 3; }'` | ||
135 | 13209 | INTLTOOL_APPLIED_VERSION=`intltool-update --version | head -1 | cut -d" " -f3` | ||
136 | 13210 | INTLTOOL_APPLIED_VERSION_AS_INT=`echo $INTLTOOL_APPLIED_VERSION | awk -F. '{ print $ 1 * 1000 + $ 2 * 100 + $ 3; }'` | ||
137 | 13208 | if test -n "0.41.0"; then | 13211 | if test -n "0.41.0"; then |
138 | 13209 | { $as_echo "$as_me:${as_lineno-$LINENO}: checking for intltool >= 0.41.0" >&5 | 13212 | { $as_echo "$as_me:${as_lineno-$LINENO}: checking for intltool >= 0.41.0" >&5 |
139 | 13210 | $as_echo_n "checking for intltool >= 0.41.0... " >&6; } | 13213 | $as_echo_n "checking for intltool >= 0.41.0... " >&6; } |
140 | 13211 | |||
141 | 13212 | INTLTOOL_REQUIRED_VERSION_AS_INT=`echo 0.41.0 | awk -F. '{ print $ 1 * 1000 + $ 2 * 100 + $ 3; }'` | ||
142 | 13213 | INTLTOOL_APPLIED_VERSION=`intltool-update --version | head -1 | cut -d" " -f3` | ||
143 | 13214 | INTLTOOL_APPLIED_VERSION_AS_INT=`echo $INTLTOOL_APPLIED_VERSION | awk -F. '{ print $ 1 * 1000 + $ 2 * 100 + $ 3; }'` | ||
144 | 13215 | |||
145 | 13216 | { $as_echo "$as_me:${as_lineno-$LINENO}: result: $INTLTOOL_APPLIED_VERSION found" >&5 | 13214 | { $as_echo "$as_me:${as_lineno-$LINENO}: result: $INTLTOOL_APPLIED_VERSION found" >&5 |
146 | 13217 | $as_echo "$INTLTOOL_APPLIED_VERSION found" >&6; } | 13215 | $as_echo "$INTLTOOL_APPLIED_VERSION found" >&6; } |
147 | 13218 | test "$INTLTOOL_APPLIED_VERSION_AS_INT" -ge "$INTLTOOL_REQUIRED_VERSION_AS_INT" || | 13216 | test "$INTLTOOL_APPLIED_VERSION_AS_INT" -ge "$INTLTOOL_REQUIRED_VERSION_AS_INT" || |
148 | @@ -13373,7 +13371,11 @@ | |||
149 | 13373 | INTLTOOL_SOUNDLIST_RULE='%.soundlist: %.soundlist.in $(INTLTOOL_MERGE) $(wildcard $(top_srcdir)/po/*.po) ; $(INTLTOOL_V_MERGE)LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -d -u -c $(top_builddir)/po/.intltool-merge-cache $(top_srcdir)/po $< $@' | 13371 | INTLTOOL_SOUNDLIST_RULE='%.soundlist: %.soundlist.in $(INTLTOOL_MERGE) $(wildcard $(top_srcdir)/po/*.po) ; $(INTLTOOL_V_MERGE)LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -d -u -c $(top_builddir)/po/.intltool-merge-cache $(top_srcdir)/po $< $@' |
150 | 13374 | INTLTOOL_UI_RULE='%.ui: %.ui.in $(INTLTOOL_MERGE) $(wildcard $(top_srcdir)/po/*.po) ; $(INTLTOOL_V_MERGE)LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -x -u -c $(top_builddir)/po/.intltool-merge-cache $(top_srcdir)/po $< $@' | 13372 | INTLTOOL_UI_RULE='%.ui: %.ui.in $(INTLTOOL_MERGE) $(wildcard $(top_srcdir)/po/*.po) ; $(INTLTOOL_V_MERGE)LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -x -u -c $(top_builddir)/po/.intltool-merge-cache $(top_srcdir)/po $< $@' |
151 | 13375 | INTLTOOL_XML_RULE='%.xml: %.xml.in $(INTLTOOL_MERGE) $(wildcard $(top_srcdir)/po/*.po) ; $(INTLTOOL_V_MERGE)LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -x -u -c $(top_builddir)/po/.intltool-merge-cache $(top_srcdir)/po $< $@' | 13373 | INTLTOOL_XML_RULE='%.xml: %.xml.in $(INTLTOOL_MERGE) $(wildcard $(top_srcdir)/po/*.po) ; $(INTLTOOL_V_MERGE)LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -x -u -c $(top_builddir)/po/.intltool-merge-cache $(top_srcdir)/po $< $@' |
152 | 13374 | if test "$INTLTOOL_APPLIED_VERSION_AS_INT" -ge 5000; then | ||
153 | 13376 | INTLTOOL_XML_NOMERGE_RULE='%.xml: %.xml.in $(INTLTOOL_MERGE) ; $(INTLTOOL_V_MERGE)LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -x -u --no-translations $< $@' | 13375 | INTLTOOL_XML_NOMERGE_RULE='%.xml: %.xml.in $(INTLTOOL_MERGE) ; $(INTLTOOL_V_MERGE)LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -x -u --no-translations $< $@' |
154 | 13376 | else | ||
155 | 13377 | INTLTOOL_XML_NOMERGE_RULE='%.xml: %.xml.in $(INTLTOOL_MERGE) ; $(INTLTOOL_V_MERGE)_it_tmp_dir=tmp.intltool.$$RANDOM && mkdir $$_it_tmp_dir && LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -x -u $$_it_tmp_dir $< $@ && rmdir $$_it_tmp_dir' | ||
156 | 13378 | fi | ||
157 | 13377 | INTLTOOL_XAM_RULE='%.xam: %.xml.in $(INTLTOOL_MERGE) $(wildcard $(top_srcdir)/po/*.po) ; $(INTLTOOL_V_MERGE)LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -x -u -c $(top_builddir)/po/.intltool-merge-cache $(top_srcdir)/po $< $@' | 13379 | INTLTOOL_XAM_RULE='%.xam: %.xml.in $(INTLTOOL_MERGE) $(wildcard $(top_srcdir)/po/*.po) ; $(INTLTOOL_V_MERGE)LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -x -u -c $(top_builddir)/po/.intltool-merge-cache $(top_srcdir)/po $< $@' |
158 | 13378 | INTLTOOL_KBD_RULE='%.kbd: %.kbd.in $(INTLTOOL_MERGE) $(wildcard $(top_srcdir)/po/*.po) ; $(INTLTOOL_V_MERGE)LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -x -u -m -c $(top_builddir)/po/.intltool-merge-cache $(top_srcdir)/po $< $@' | 13380 | INTLTOOL_KBD_RULE='%.kbd: %.kbd.in $(INTLTOOL_MERGE) $(wildcard $(top_srcdir)/po/*.po) ; $(INTLTOOL_V_MERGE)LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -x -u -m -c $(top_builddir)/po/.intltool-merge-cache $(top_srcdir)/po $< $@' |
159 | 13379 | INTLTOOL_CAVES_RULE='%.caves: %.caves.in $(INTLTOOL_MERGE) $(wildcard $(top_srcdir)/po/*.po) ; $(INTLTOOL_V_MERGE)LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -d -u -c $(top_builddir)/po/.intltool-merge-cache $(top_srcdir)/po $< $@' | 13381 | INTLTOOL_CAVES_RULE='%.caves: %.caves.in $(INTLTOOL_MERGE) $(wildcard $(top_srcdir)/po/*.po) ; $(INTLTOOL_V_MERGE)LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -d -u -c $(top_builddir)/po/.intltool-merge-cache $(top_srcdir)/po $< $@' |
160 | @@ -15041,7 +15043,7 @@ | |||
161 | 15041 | # report actual input values of CONFIG_FILES etc. instead of their | 15043 | # report actual input values of CONFIG_FILES etc. instead of their |
162 | 15042 | # values after options handling. | 15044 | # values after options handling. |
163 | 15043 | ac_log=" | 15045 | ac_log=" |
165 | 15044 | This file was extended by indicator-datetime $as_me 0.3.91, which was | 15046 | This file was extended by indicator-datetime $as_me 0.3.92, which was |
166 | 15045 | generated by GNU Autoconf 2.68. Invocation command line was | 15047 | generated by GNU Autoconf 2.68. Invocation command line was |
167 | 15046 | 15048 | ||
168 | 15047 | CONFIG_FILES = $CONFIG_FILES | 15049 | CONFIG_FILES = $CONFIG_FILES |
169 | @@ -15108,7 +15110,7 @@ | |||
170 | 15108 | cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1 | 15110 | cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1 |
171 | 15109 | ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`" | 15111 | ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`" |
172 | 15110 | ac_cs_version="\\ | 15112 | ac_cs_version="\\ |
174 | 15111 | indicator-datetime config.status 0.3.91 | 15113 | indicator-datetime config.status 0.3.92 |
175 | 15112 | configured by $0, generated by GNU Autoconf 2.68, | 15114 | configured by $0, generated by GNU Autoconf 2.68, |
176 | 15113 | with options \\"\$ac_cs_config\\" | 15115 | with options \\"\$ac_cs_config\\" |
177 | 15114 | 15116 | ||
178 | 15115 | 15117 | ||
179 | === modified file 'configure.ac' | |||
180 | --- configure.ac 2012-03-08 22:57:20 +0000 | |||
181 | +++ configure.ac 2012-03-21 16:52:25 +0000 | |||
182 | @@ -1,5 +1,5 @@ | |||
183 | 1 | AC_INIT([indicator-datetime], | 1 | AC_INIT([indicator-datetime], |
185 | 2 | [0.3.91], | 2 | [0.3.92], |
186 | 3 | [http://bugs.launchpad.net/indicator-datetime], | 3 | [http://bugs.launchpad.net/indicator-datetime], |
187 | 4 | [indicator-datetime], | 4 | [indicator-datetime], |
188 | 5 | [http://launchpad.net/indicator-datetime]) | 5 | [http://launchpad.net/indicator-datetime]) |
189 | 6 | 6 | ||
190 | === modified file 'debian/changelog' | |||
191 | --- debian/changelog 2012-03-09 12:49:52 +0000 | |||
192 | +++ debian/changelog 2012-03-21 16:52:25 +0000 | |||
193 | @@ -1,3 +1,10 @@ | |||
194 | 1 | indicator-datetime (0.3.92-0ubuntu1~ppa1) precise; urgency=low | ||
195 | 2 | |||
196 | 3 | * New upstream release. | ||
197 | 4 | * Fix several memory leaks (LP: #772340, LP: #957320) | ||
198 | 5 | |||
199 | 6 | -- Charles Kerr <charles.kerr@canonical.com> Wed, 21 Mar 2012 11:22:20 -0500 | ||
200 | 7 | |||
201 | 1 | indicator-datetime (0.3.91-0ubuntu1) precise; urgency=low | 8 | indicator-datetime (0.3.91-0ubuntu1) precise; urgency=low |
202 | 2 | 9 | ||
203 | 3 | * New upstream release. | 10 | * New upstream release. |
204 | 4 | 11 | ||
205 | === modified file 'm4/intltool.m4' | |||
206 | --- m4/intltool.m4 2012-02-17 22:15:25 +0000 | |||
207 | +++ m4/intltool.m4 2012-03-21 16:52:25 +0000 | |||
208 | @@ -23,7 +23,7 @@ | |||
209 | 23 | ## the same distribution terms that you use for the rest of that program. | 23 | ## the same distribution terms that you use for the rest of that program. |
210 | 24 | 24 | ||
211 | 25 | dnl IT_PROG_INTLTOOL([MINIMUM-VERSION], [no-xml]) | 25 | dnl IT_PROG_INTLTOOL([MINIMUM-VERSION], [no-xml]) |
213 | 26 | # serial 41 IT_PROG_INTLTOOL | 26 | # serial 42 IT_PROG_INTLTOOL |
214 | 27 | AC_DEFUN([IT_PROG_INTLTOOL], [ | 27 | AC_DEFUN([IT_PROG_INTLTOOL], [ |
215 | 28 | AC_PREREQ([2.50])dnl | 28 | AC_PREREQ([2.50])dnl |
216 | 29 | AC_REQUIRE([AM_NLS])dnl | 29 | AC_REQUIRE([AM_NLS])dnl |
217 | @@ -36,13 +36,11 @@ | |||
218 | 36 | ;; | 36 | ;; |
219 | 37 | esac | 37 | esac |
220 | 38 | 38 | ||
221 | 39 | INTLTOOL_REQUIRED_VERSION_AS_INT=`echo $1 | awk -F. '{ print $ 1 * 1000 + $ 2 * 100 + $ 3; }'` | ||
222 | 40 | INTLTOOL_APPLIED_VERSION=`intltool-update --version | head -1 | cut -d" " -f3` | ||
223 | 41 | INTLTOOL_APPLIED_VERSION_AS_INT=`echo $INTLTOOL_APPLIED_VERSION | awk -F. '{ print $ 1 * 1000 + $ 2 * 100 + $ 3; }'` | ||
224 | 39 | if test -n "$1"; then | 42 | if test -n "$1"; then |
225 | 40 | AC_MSG_CHECKING([for intltool >= $1]) | 43 | AC_MSG_CHECKING([for intltool >= $1]) |
226 | 41 | |||
227 | 42 | INTLTOOL_REQUIRED_VERSION_AS_INT=`echo $1 | awk -F. '{ print $ 1 * 1000 + $ 2 * 100 + $ 3; }'` | ||
228 | 43 | INTLTOOL_APPLIED_VERSION=`intltool-update --version | head -1 | cut -d" " -f3` | ||
229 | 44 | [INTLTOOL_APPLIED_VERSION_AS_INT=`echo $INTLTOOL_APPLIED_VERSION | awk -F. '{ print $ 1 * 1000 + $ 2 * 100 + $ 3; }'` | ||
230 | 45 | ] | ||
231 | 46 | AC_MSG_RESULT([$INTLTOOL_APPLIED_VERSION found]) | 44 | AC_MSG_RESULT([$INTLTOOL_APPLIED_VERSION found]) |
232 | 47 | test "$INTLTOOL_APPLIED_VERSION_AS_INT" -ge "$INTLTOOL_REQUIRED_VERSION_AS_INT" || | 45 | test "$INTLTOOL_APPLIED_VERSION_AS_INT" -ge "$INTLTOOL_REQUIRED_VERSION_AS_INT" || |
233 | 48 | AC_MSG_ERROR([Your intltool is too old. You need intltool $1 or later.]) | 46 | AC_MSG_ERROR([Your intltool is too old. You need intltool $1 or later.]) |
234 | @@ -85,7 +83,11 @@ | |||
235 | 85 | INTLTOOL_SOUNDLIST_RULE='%.soundlist: %.soundlist.in $(INTLTOOL_MERGE) $(wildcard $(top_srcdir)/po/*.po) ; $(INTLTOOL_V_MERGE)LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -d -u -c $(top_builddir)/po/.intltool-merge-cache $(top_srcdir)/po $< [$]@' | 83 | INTLTOOL_SOUNDLIST_RULE='%.soundlist: %.soundlist.in $(INTLTOOL_MERGE) $(wildcard $(top_srcdir)/po/*.po) ; $(INTLTOOL_V_MERGE)LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -d -u -c $(top_builddir)/po/.intltool-merge-cache $(top_srcdir)/po $< [$]@' |
236 | 86 | INTLTOOL_UI_RULE='%.ui: %.ui.in $(INTLTOOL_MERGE) $(wildcard $(top_srcdir)/po/*.po) ; $(INTLTOOL_V_MERGE)LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -x -u -c $(top_builddir)/po/.intltool-merge-cache $(top_srcdir)/po $< [$]@' | 84 | INTLTOOL_UI_RULE='%.ui: %.ui.in $(INTLTOOL_MERGE) $(wildcard $(top_srcdir)/po/*.po) ; $(INTLTOOL_V_MERGE)LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -x -u -c $(top_builddir)/po/.intltool-merge-cache $(top_srcdir)/po $< [$]@' |
237 | 87 | INTLTOOL_XML_RULE='%.xml: %.xml.in $(INTLTOOL_MERGE) $(wildcard $(top_srcdir)/po/*.po) ; $(INTLTOOL_V_MERGE)LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -x -u -c $(top_builddir)/po/.intltool-merge-cache $(top_srcdir)/po $< [$]@' | 85 | INTLTOOL_XML_RULE='%.xml: %.xml.in $(INTLTOOL_MERGE) $(wildcard $(top_srcdir)/po/*.po) ; $(INTLTOOL_V_MERGE)LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -x -u -c $(top_builddir)/po/.intltool-merge-cache $(top_srcdir)/po $< [$]@' |
238 | 86 | if test "$INTLTOOL_APPLIED_VERSION_AS_INT" -ge 5000; then | ||
239 | 88 | INTLTOOL_XML_NOMERGE_RULE='%.xml: %.xml.in $(INTLTOOL_MERGE) ; $(INTLTOOL_V_MERGE)LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -x -u --no-translations $< [$]@' | 87 | INTLTOOL_XML_NOMERGE_RULE='%.xml: %.xml.in $(INTLTOOL_MERGE) ; $(INTLTOOL_V_MERGE)LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -x -u --no-translations $< [$]@' |
240 | 88 | else | ||
241 | 89 | INTLTOOL_XML_NOMERGE_RULE='%.xml: %.xml.in $(INTLTOOL_MERGE) ; $(INTLTOOL_V_MERGE)_it_tmp_dir=tmp.intltool.[$][$]RANDOM && mkdir [$][$]_it_tmp_dir && LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -x -u [$][$]_it_tmp_dir $< [$]@ && rmdir [$][$]_it_tmp_dir' | ||
242 | 90 | fi | ||
243 | 89 | INTLTOOL_XAM_RULE='%.xam: %.xml.in $(INTLTOOL_MERGE) $(wildcard $(top_srcdir)/po/*.po) ; $(INTLTOOL_V_MERGE)LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -x -u -c $(top_builddir)/po/.intltool-merge-cache $(top_srcdir)/po $< [$]@' | 91 | INTLTOOL_XAM_RULE='%.xam: %.xml.in $(INTLTOOL_MERGE) $(wildcard $(top_srcdir)/po/*.po) ; $(INTLTOOL_V_MERGE)LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -x -u -c $(top_builddir)/po/.intltool-merge-cache $(top_srcdir)/po $< [$]@' |
244 | 90 | INTLTOOL_KBD_RULE='%.kbd: %.kbd.in $(INTLTOOL_MERGE) $(wildcard $(top_srcdir)/po/*.po) ; $(INTLTOOL_V_MERGE)LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -x -u -m -c $(top_builddir)/po/.intltool-merge-cache $(top_srcdir)/po $< [$]@' | 92 | INTLTOOL_KBD_RULE='%.kbd: %.kbd.in $(INTLTOOL_MERGE) $(wildcard $(top_srcdir)/po/*.po) ; $(INTLTOOL_V_MERGE)LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -x -u -m -c $(top_builddir)/po/.intltool-merge-cache $(top_srcdir)/po $< [$]@' |
245 | 91 | INTLTOOL_CAVES_RULE='%.caves: %.caves.in $(INTLTOOL_MERGE) $(wildcard $(top_srcdir)/po/*.po) ; $(INTLTOOL_V_MERGE)LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -d -u -c $(top_builddir)/po/.intltool-merge-cache $(top_srcdir)/po $< [$]@' | 93 | INTLTOOL_CAVES_RULE='%.caves: %.caves.in $(INTLTOOL_MERGE) $(wildcard $(top_srcdir)/po/*.po) ; $(INTLTOOL_V_MERGE)LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -d -u -c $(top_builddir)/po/.intltool-merge-cache $(top_srcdir)/po $< [$]@' |
246 | 92 | 94 | ||
247 | === modified file 'src/datetime-service.c' | |||
248 | --- src/datetime-service.c 2012-03-08 22:57:20 +0000 | |||
249 | +++ src/datetime-service.c 2012-03-21 16:52:25 +0000 | |||
250 | @@ -273,7 +273,7 @@ | |||
251 | 273 | 273 | ||
252 | 274 | if (error != NULL) { | 274 | if (error != NULL) { |
253 | 275 | g_warning("Could not set timezone for SettingsDaemon: %s", error->message); | 275 | g_warning("Could not set timezone for SettingsDaemon: %s", error->message); |
255 | 276 | g_error_free(error); | 276 | g_clear_error (&error); |
256 | 277 | return; | 277 | return; |
257 | 278 | } | 278 | } |
258 | 279 | 279 | ||
259 | @@ -289,7 +289,7 @@ | |||
260 | 289 | 289 | ||
261 | 290 | if (error != NULL) { | 290 | if (error != NULL) { |
262 | 291 | g_warning("Could not grab DBus proxy for SettingsDaemon: %s", error->message); | 291 | g_warning("Could not grab DBus proxy for SettingsDaemon: %s", error->message); |
264 | 292 | g_error_free(error); | 292 | g_clear_error (&error); |
265 | 293 | g_free (zone); | 293 | g_free (zone); |
266 | 294 | return; | 294 | return; |
267 | 295 | } | 295 | } |
268 | @@ -363,7 +363,7 @@ | |||
269 | 363 | g_debug("Issuing command '%s'", command); | 363 | g_debug("Issuing command '%s'", command); |
270 | 364 | if (!g_spawn_command_line_async(command, &error)) { | 364 | if (!g_spawn_command_line_async(command, &error)) { |
271 | 365 | g_warning("Unable to start %s: %s", (char *)command, error->message); | 365 | g_warning("Unable to start %s: %s", (char *)command, error->message); |
273 | 366 | g_error_free(error); | 366 | g_clear_error (&error); |
274 | 367 | } | 367 | } |
275 | 368 | } | 368 | } |
276 | 369 | 369 | ||
277 | @@ -532,7 +532,7 @@ | |||
278 | 532 | GSList *accounts_list = gconf_client_get_list (gconf, "/apps/evolution/mail/accounts", GCONF_VALUE_STRING, NULL); | 532 | GSList *accounts_list = gconf_client_get_list (gconf, "/apps/evolution/mail/accounts", GCONF_VALUE_STRING, NULL); |
279 | 533 | const guint n = g_slist_length (accounts_list); | 533 | const guint n = g_slist_length (accounts_list); |
280 | 534 | g_debug ("found %u evolution accounts", n); | 534 | g_debug ("found %u evolution accounts", n); |
282 | 535 | g_slist_free (accounts_list); | 535 | g_slist_free_full (accounts_list, g_free); |
283 | 536 | return n > 0; | 536 | return n > 0; |
284 | 537 | } | 537 | } |
285 | 538 | 538 | ||
286 | @@ -613,22 +613,43 @@ | |||
287 | 613 | } | 613 | } |
288 | 614 | 614 | ||
289 | 615 | static gint | 615 | static gint |
299 | 616 | compare_comp_instances (gconstpointer a, | 616 | compare_comp_instances (gconstpointer ga, gconstpointer gb) |
300 | 617 | gconstpointer b) | 617 | { |
301 | 618 | { | 618 | const struct comp_instance * a = ga; |
302 | 619 | const struct comp_instance *ci_a = a; | 619 | const struct comp_instance * b = gb; |
303 | 620 | const struct comp_instance *ci_b = b; | 620 | |
304 | 621 | time_t d = ci_a->start - ci_b->start; | 621 | /* sort by start time */ |
305 | 622 | if (d < 0) return -1; | 622 | if (a->start < b->start) return -1; |
306 | 623 | else if (d > 0) return 1; | 623 | if (a->start > b->start) return 1; |
307 | 624 | return 0; | 624 | return 0; |
308 | 625 | } | ||
309 | 626 | |||
310 | 627 | static struct comp_instance* | ||
311 | 628 | comp_instance_new (ECalComponent * comp, time_t start, time_t end, ESource * source) | ||
312 | 629 | { | ||
313 | 630 | g_debug("Using times start %s, end %s", ctime(&start), ctime(&end)); | ||
314 | 631 | |||
315 | 632 | struct comp_instance *ci = g_new (struct comp_instance, 1); | ||
316 | 633 | ci->comp = g_object_ref (comp); | ||
317 | 634 | ci->source = source; | ||
318 | 635 | ci->start = start; | ||
319 | 636 | ci->end = end; | ||
320 | 637 | return ci; | ||
321 | 638 | } | ||
322 | 639 | static void | ||
323 | 640 | comp_instance_free (struct comp_instance* ci) | ||
324 | 641 | { | ||
325 | 642 | if (ci != NULL) { | ||
326 | 643 | g_clear_object (&ci->comp); | ||
327 | 644 | g_free (ci); | ||
328 | 645 | } | ||
329 | 625 | } | 646 | } |
330 | 626 | 647 | ||
331 | 627 | static gboolean | 648 | static gboolean |
336 | 628 | populate_appointment_instances (ECalComponent *comp, | 649 | populate_appointment_instances (ECalComponent * comp, |
337 | 629 | time_t instance_start, | 650 | time_t start, |
338 | 630 | time_t instance_end, | 651 | time_t end, |
339 | 631 | gpointer data) | 652 | gpointer data) |
340 | 632 | { | 653 | { |
341 | 633 | g_debug("Appending item %p", comp); | 654 | g_debug("Appending item %p", comp); |
342 | 634 | 655 | ||
343 | @@ -638,20 +659,9 @@ | |||
344 | 638 | icalproperty_status status; | 659 | icalproperty_status status; |
345 | 639 | e_cal_component_get_status (comp, &status); | 660 | e_cal_component_get_status (comp, &status); |
346 | 640 | if (status == ICAL_STATUS_COMPLETED || status == ICAL_STATUS_CANCELLED) return FALSE; | 661 | if (status == ICAL_STATUS_COMPLETED || status == ICAL_STATUS_CANCELLED) return FALSE; |
347 | 641 | |||
348 | 642 | g_object_ref(comp); | ||
349 | 643 | 662 | ||
361 | 644 | struct comp_instance *ci; | 663 | struct comp_instance *ci = comp_instance_new (comp, start, end, E_SOURCE(data)); |
362 | 645 | ci = g_new (struct comp_instance, 1); | 664 | comp_instances = g_list_append (comp_instances, ci); |
352 | 646 | |||
353 | 647 | g_debug("Using times start %s, end %s", ctime(&instance_start), ctime(&instance_end)); | ||
354 | 648 | |||
355 | 649 | ci->comp = comp; | ||
356 | 650 | ci->source = E_SOURCE(data); | ||
357 | 651 | ci->start = instance_start; | ||
358 | 652 | ci->end = instance_end; | ||
359 | 653 | |||
360 | 654 | comp_instances = g_list_append(comp_instances, ci); | ||
363 | 655 | return TRUE; | 665 | return TRUE; |
364 | 656 | } | 666 | } |
365 | 657 | 667 | ||
366 | @@ -719,25 +729,18 @@ | |||
367 | 719 | 729 | ||
368 | 720 | if (!e_cal_get_sources(&sources, E_CAL_SOURCE_TYPE_EVENT, &gerror)) { | 730 | if (!e_cal_get_sources(&sources, E_CAL_SOURCE_TYPE_EVENT, &gerror)) { |
369 | 721 | g_debug("Failed to get ecal sources\n"); | 731 | g_debug("Failed to get ecal sources\n"); |
370 | 732 | g_clear_error (&gerror); | ||
371 | 722 | return FALSE; | 733 | return FALSE; |
372 | 723 | } | 734 | } |
373 | 724 | 735 | ||
383 | 725 | // Free comp_instances if not NULL | 736 | // clear any previous comp_instances |
384 | 726 | if (comp_instances != NULL) { | 737 | g_list_free_full (comp_instances, (GDestroyNotify)comp_instance_free); |
385 | 727 | g_debug("Freeing comp_instances: may be an overlap\n"); | 738 | comp_instances = NULL; |
377 | 728 | for (l = comp_instances; l; l = l->next) { | ||
378 | 729 | const struct comp_instance *ci = l->data; | ||
379 | 730 | g_object_unref(ci->comp); | ||
380 | 731 | } | ||
381 | 732 | g_list_free(comp_instances); | ||
382 | 733 | comp_instances = NULL; | ||
386 | 734 | 739 | ||
387 | 735 | } | ||
388 | 736 | GSList *cal_list = gconf_client_get_list(gconf, "/apps/evolution/calendar/display/selected_calendars", GCONF_VALUE_STRING, &gerror); | 740 | GSList *cal_list = gconf_client_get_list(gconf, "/apps/evolution/calendar/display/selected_calendars", GCONF_VALUE_STRING, &gerror); |
389 | 737 | if (gerror) { | 741 | if (gerror) { |
390 | 738 | g_debug("Failed to get evolution preference for enabled calendars"); | 742 | g_debug("Failed to get evolution preference for enabled calendars"); |
393 | 739 | g_error_free(gerror); | 743 | g_clear_error (&gerror); |
392 | 740 | gerror = NULL; | ||
394 | 741 | cal_list = NULL; | 744 | cal_list = NULL; |
395 | 742 | } | 745 | } |
396 | 743 | 746 | ||
397 | @@ -759,39 +762,33 @@ | |||
398 | 759 | } | 762 | } |
399 | 760 | if (current_zone && !e_cal_set_default_timezone(ecal, current_zone, &gerror)) { | 763 | if (current_zone && !e_cal_set_default_timezone(ecal, current_zone, &gerror)) { |
400 | 761 | g_debug("Failed to set ecal default timezone %s", gerror->message); | 764 | g_debug("Failed to set ecal default timezone %s", gerror->message); |
403 | 762 | g_error_free(gerror); | 765 | g_clear_error (&gerror); |
402 | 763 | gerror = NULL; | ||
404 | 764 | g_object_unref(ecal); | 766 | g_object_unref(ecal); |
405 | 765 | continue; | 767 | continue; |
406 | 766 | } | 768 | } |
407 | 767 | 769 | ||
408 | 768 | if (!e_cal_open(ecal, FALSE, &gerror)) { | 770 | if (!e_cal_open(ecal, FALSE, &gerror)) { |
409 | 769 | g_debug("Failed to get ecal sources %s", gerror->message); | 771 | g_debug("Failed to get ecal sources %s", gerror->message); |
412 | 770 | g_error_free(gerror); | 772 | g_clear_error (&gerror); |
411 | 771 | gerror = NULL; | ||
413 | 772 | g_object_unref(ecal); | 773 | g_object_unref(ecal); |
414 | 773 | continue; | 774 | continue; |
415 | 774 | } | 775 | } |
416 | 776 | |||
417 | 775 | const gchar *ecal_uid = e_source_peek_uid(source); | 777 | const gchar *ecal_uid = e_source_peek_uid(source); |
418 | 776 | gboolean match = FALSE; | ||
419 | 777 | g_debug("Checking ecal_uid is enabled: %s", ecal_uid); | 778 | g_debug("Checking ecal_uid is enabled: %s", ecal_uid); |
428 | 778 | for (i = 0; i<g_slist_length(cal_list);i++) { | 779 | const gboolean in_list = g_slist_find_custom (cal_list, ecal_uid, (GCompareFunc)g_strcmp0) != NULL; |
429 | 779 | char *cuid = (char *)g_slist_nth_data(cal_list, i); | 780 | if (!in_list) { |
422 | 780 | if (g_strcmp0(cuid, ecal_uid) == 0) { | ||
423 | 781 | match = TRUE; | ||
424 | 782 | break; | ||
425 | 783 | } | ||
426 | 784 | } | ||
427 | 785 | if (!match) { | ||
430 | 786 | g_object_unref(ecal); | 781 | g_object_unref(ecal); |
431 | 787 | continue; | 782 | continue; |
432 | 788 | } | 783 | } |
433 | 784 | |||
434 | 789 | g_debug("ecal_uid is enabled, generating instances"); | 785 | g_debug("ecal_uid is enabled, generating instances"); |
437 | 790 | 786 | e_cal_generate_instances (ecal, t1, t2, (ECalRecurInstanceFn) populate_appointment_instances, source); | |
436 | 791 | e_cal_generate_instances (ecal, t1, t2, (ECalRecurInstanceFn) populate_appointment_instances, (gpointer) source); | ||
438 | 792 | g_object_unref(ecal); | 787 | g_object_unref(ecal); |
439 | 793 | } | 788 | } |
440 | 794 | } | 789 | } |
441 | 790 | g_slist_free_full (cal_list, g_free); | ||
442 | 791 | |||
443 | 795 | g_debug("Number of ECalComponents returned: %d", g_list_length(comp_instances)); | 792 | g_debug("Number of ECalComponents returned: %d", g_list_length(comp_instances)); |
444 | 796 | GList *sorted_comp_instances = g_list_sort(comp_instances, compare_comp_instances); | 793 | GList *sorted_comp_instances = g_list_sort(comp_instances, compare_comp_instances); |
445 | 797 | comp_instances = NULL; | 794 | comp_instances = NULL; |
446 | @@ -821,13 +818,12 @@ | |||
447 | 821 | apt_output = SETTINGS_TIME_12_HOUR; | 818 | apt_output = SETTINGS_TIME_12_HOUR; |
448 | 822 | } else if (g_strcmp0(time_format_str, "24-hour") == 0) { | 819 | } else if (g_strcmp0(time_format_str, "24-hour") == 0) { |
449 | 823 | apt_output = SETTINGS_TIME_24_HOUR; | 820 | apt_output = SETTINGS_TIME_24_HOUR; |
450 | 821 | } else if (is_locale_12h()) { | ||
451 | 822 | apt_output = SETTINGS_TIME_12_HOUR; | ||
452 | 824 | } else { | 823 | } else { |
458 | 825 | if (is_locale_12h()) { | 824 | apt_output = SETTINGS_TIME_24_HOUR; |
454 | 826 | apt_output = SETTINGS_TIME_12_HOUR; | ||
455 | 827 | } else { | ||
456 | 828 | apt_output = SETTINGS_TIME_24_HOUR; | ||
457 | 829 | } | ||
459 | 830 | } | 825 | } |
460 | 826 | g_free (time_format_str); | ||
461 | 831 | 827 | ||
462 | 832 | GVariantBuilder markeddays; | 828 | GVariantBuilder markeddays; |
463 | 833 | g_variant_builder_init (&markeddays, G_VARIANT_TYPE ("ai")); | 829 | g_variant_builder_init (&markeddays, G_VARIANT_TYPE ("ai")); |
464 | @@ -1001,6 +997,7 @@ | |||
465 | 1001 | } | 997 | } |
466 | 1002 | 998 | ||
467 | 1003 | dbusmenu_menuitem_property_set_image (item, APPOINTMENT_MENUITEM_PROP_ICON, pixbuf); | 999 | dbusmenu_menuitem_property_set_image (item, APPOINTMENT_MENUITEM_PROP_ICON, pixbuf); |
468 | 1000 | g_clear_object (&pixbuf); | ||
469 | 1004 | } else { | 1001 | } else { |
470 | 1005 | g_debug("Creating pixbuf from surface failed"); | 1002 | g_debug("Creating pixbuf from surface failed"); |
471 | 1006 | } | 1003 | } |
472 | @@ -1010,15 +1007,15 @@ | |||
473 | 1010 | g_debug("Adding appointment: %p", item); | 1007 | g_debug("Adding appointment: %p", item); |
474 | 1011 | } | 1008 | } |
475 | 1012 | 1009 | ||
482 | 1013 | if (gerror != NULL) g_error_free(gerror); | 1010 | g_clear_error (&gerror); |
483 | 1014 | for (l = sorted_comp_instances; l; l = l->next) { | 1011 | |
484 | 1015 | const struct comp_instance *ci = l->data; | 1012 | g_list_free_full (sorted_comp_instances, (GDestroyNotify)comp_instance_free); |
485 | 1016 | g_object_unref(ci->comp); | 1013 | sorted_comp_instances = NULL; |
480 | 1017 | } | ||
481 | 1018 | g_list_free(sorted_comp_instances); | ||
486 | 1019 | 1014 | ||
487 | 1020 | GVariant * marks = g_variant_builder_end (&markeddays); | 1015 | GVariant * marks = g_variant_builder_end (&markeddays); |
488 | 1021 | dbusmenu_menuitem_property_set_variant (calendar, CALENDAR_MENUITEM_PROP_MARKS, marks); | 1016 | dbusmenu_menuitem_property_set_variant (calendar, CALENDAR_MENUITEM_PROP_MARKS, marks); |
489 | 1017 | |||
490 | 1018 | g_clear_object (&sources); | ||
491 | 1022 | 1019 | ||
492 | 1023 | updating_appointments = FALSE; | 1020 | updating_appointments = FALSE; |
493 | 1024 | g_debug("End of objects"); | 1021 | g_debug("End of objects"); |
494 | @@ -1205,7 +1202,7 @@ | |||
495 | 1205 | 1202 | ||
496 | 1206 | if (error != NULL) { | 1203 | if (error != NULL) { |
497 | 1207 | g_warning("Could not grab DBus proxy for ConsoleKit: %s", error->message); | 1204 | g_warning("Could not grab DBus proxy for ConsoleKit: %s", error->message); |
499 | 1208 | g_error_free(error); | 1205 | g_clear_error (&error); |
500 | 1209 | return; | 1206 | return; |
501 | 1210 | } | 1207 | } |
502 | 1211 | 1208 | ||
503 | @@ -1218,6 +1215,7 @@ | |||
504 | 1218 | { | 1215 | { |
505 | 1219 | if (error != NULL) { | 1216 | if (error != NULL) { |
506 | 1220 | g_warning("Unable to get Geoclue address: %s", error->message); | 1217 | g_warning("Unable to get Geoclue address: %s", error->message); |
507 | 1218 | g_clear_error (&error); | ||
508 | 1221 | return; | 1219 | return; |
509 | 1222 | } | 1220 | } |
510 | 1223 | 1221 | ||
511 | @@ -1279,6 +1277,7 @@ | |||
512 | 1279 | { | 1277 | { |
513 | 1280 | if (error != NULL) { | 1278 | if (error != NULL) { |
514 | 1281 | g_warning("Unable to create GeoClue address: %s", error->message); | 1279 | g_warning("Unable to create GeoClue address: %s", error->message); |
515 | 1280 | g_clear_error (&error); | ||
516 | 1282 | return; | 1281 | return; |
517 | 1283 | } | 1282 | } |
518 | 1284 | 1283 | ||
519 | @@ -1305,6 +1304,7 @@ | |||
520 | 1305 | { | 1304 | { |
521 | 1306 | if (error != NULL) { | 1305 | if (error != NULL) { |
522 | 1307 | g_warning("Unable to set Geoclue requirements: %s", error->message); | 1306 | g_warning("Unable to set Geoclue requirements: %s", error->message); |
523 | 1307 | g_clear_error (&error); | ||
524 | 1308 | } | 1308 | } |
525 | 1309 | return; | 1309 | return; |
526 | 1310 | } | 1310 | } |
527 | @@ -1367,6 +1367,7 @@ | |||
528 | 1367 | 1367 | ||
529 | 1368 | if (error != NULL) { | 1368 | if (error != NULL) { |
530 | 1369 | g_warning("Unable to get a GeoClue client! '%s' Geolocation based timezone support will not be available.", error->message); | 1369 | g_warning("Unable to get a GeoClue client! '%s' Geolocation based timezone support will not be available.", error->message); |
531 | 1370 | g_clear_error (&error); | ||
532 | 1370 | return; | 1371 | return; |
533 | 1371 | } | 1372 | } |
534 | 1372 | 1373 |