Merge lp:~indicator-applet-developers/libappindicator/ubuntu into lp:~ubuntu-desktop/libappindicator/ubuntu

Proposed by Ted Gould
Status: Merged
Merged at revision: 265
Proposed branch: lp:~indicator-applet-developers/libappindicator/ubuntu
Merge into: lp:~ubuntu-desktop/libappindicator/ubuntu
Diff against target: 202 lines (+36/-25)
7 files modified
ChangeLog (+12/-0)
configure (+10/-10)
configure.ac (+2/-2)
debian/changelog (+7/-0)
docs/reference/libappindicator-docs.sgml (+1/-1)
docs/reference/version.xml (+1/-1)
src/app-indicator.c (+3/-11)
To merge this branch: bzr merge lp:~indicator-applet-developers/libappindicator/ubuntu
Reviewer Review Type Date Requested Status
Ken VanDine Pending
Review via email: mp+54607@code.launchpad.net
To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'ChangeLog'
--- ChangeLog 2011-03-16 18:37:03 +0000
+++ ChangeLog 2011-03-23 20:57:29 +0000
@@ -1,5 +1,17 @@
1# Generated by Makefile. Do not edit.1# Generated by Makefile. Do not edit.
22
32011-03-23 Ted Gould <ted@gould.cx>
4
5 0.3.0
6
72011-03-23 Ted Gould <ted@gould.cx>
8
9 Use icon-name instead of GIcon in the fallback GtkStatusIcon
10
112011-03-23 Ted Gould <ted@gould.cx>
12
13 Set gtk_status_icon using icon_name instead of gicon
14
32011-03-16 Ted Gould <ted@gould.cx>152011-03-16 Ted Gould <ted@gould.cx>
416
5 0.2.9917 0.2.99
618
=== modified file 'configure'
--- configure 2011-03-16 18:37:03 +0000
+++ configure 2011-03-23 20:57:29 +0000
@@ -1,6 +1,6 @@
1#! /bin/sh1#! /bin/sh
2# Guess values for system-dependent variables and create Makefiles.2# Guess values for system-dependent variables and create Makefiles.
3# Generated by GNU Autoconf 2.67 for libappindicator 0.2.99.3# Generated by GNU Autoconf 2.67 for libappindicator 0.3.0.
4#4#
5# Report bugs to <ted@canonical.com>.5# Report bugs to <ted@canonical.com>.
6#6#
@@ -763,8 +763,8 @@
763# Identity of this package.763# Identity of this package.
764PACKAGE_NAME='libappindicator'764PACKAGE_NAME='libappindicator'
765PACKAGE_TARNAME='libappindicator'765PACKAGE_TARNAME='libappindicator'
766PACKAGE_VERSION='0.2.99'766PACKAGE_VERSION='0.3.0'
767PACKAGE_STRING='libappindicator 0.2.99'767PACKAGE_STRING='libappindicator 0.3.0'
768PACKAGE_BUGREPORT='ted@canonical.com'768PACKAGE_BUGREPORT='ted@canonical.com'
769PACKAGE_URL=''769PACKAGE_URL=''
770770
@@ -1581,7 +1581,7 @@
1581 # Omit some internal or obsolete options to make the list less imposing.1581 # Omit some internal or obsolete options to make the list less imposing.
1582 # This message is too long to be a string in the A/UX 3.1 sh.1582 # This message is too long to be a string in the A/UX 3.1 sh.
1583 cat <<_ACEOF1583 cat <<_ACEOF
1584\`configure' configures libappindicator 0.2.99 to adapt to many kinds of systems.1584\`configure' configures libappindicator 0.3.0 to adapt to many kinds of systems.
15851585
1586Usage: $0 [OPTION]... [VAR=VALUE]...1586Usage: $0 [OPTION]... [VAR=VALUE]...
15871587
@@ -1651,7 +1651,7 @@
16511651
1652if test -n "$ac_init_help"; then1652if test -n "$ac_init_help"; then
1653 case $ac_init_help in1653 case $ac_init_help in
1654 short | recursive ) echo "Configuration of libappindicator 0.2.99:";;1654 short | recursive ) echo "Configuration of libappindicator 0.3.0:";;
1655 esac1655 esac
1656 cat <<\_ACEOF1656 cat <<\_ACEOF
16571657
@@ -1793,7 +1793,7 @@
1793test -n "$ac_init_help" && exit $ac_status1793test -n "$ac_init_help" && exit $ac_status
1794if $ac_init_version; then1794if $ac_init_version; then
1795 cat <<\_ACEOF1795 cat <<\_ACEOF
1796libappindicator configure 0.2.991796libappindicator configure 0.3.0
1797generated by GNU Autoconf 2.671797generated by GNU Autoconf 2.67
17981798
1799Copyright (C) 2010 Free Software Foundation, Inc.1799Copyright (C) 2010 Free Software Foundation, Inc.
@@ -2073,7 +2073,7 @@
2073This file contains any messages produced by compilers while2073This file contains any messages produced by compilers while
2074running configure, to aid debugging if configure makes a mistake.2074running configure, to aid debugging if configure makes a mistake.
20752075
2076It was created by libappindicator $as_me 0.2.99, which was2076It was created by libappindicator $as_me 0.3.0, which was
2077generated by GNU Autoconf 2.67. Invocation command line was2077generated by GNU Autoconf 2.67. Invocation command line was
20782078
2079 $ $0 $@2079 $ $0 $@
@@ -2894,7 +2894,7 @@
28942894
2895# Define the identity of the package.2895# Define the identity of the package.
2896 PACKAGE=libappindicator2896 PACKAGE=libappindicator
2897 VERSION=0.2.992897 VERSION=0.3.0
28982898
28992899
2900cat >>confdefs.h <<_ACEOF2900cat >>confdefs.h <<_ACEOF
@@ -14120,7 +14120,7 @@
14120# report actual input values of CONFIG_FILES etc. instead of their14120# report actual input values of CONFIG_FILES etc. instead of their
14121# values after options handling.14121# values after options handling.
14122ac_log="14122ac_log="
14123This file was extended by libappindicator $as_me 0.2.99, which was14123This file was extended by libappindicator $as_me 0.3.0, which was
14124generated by GNU Autoconf 2.67. Invocation command line was14124generated by GNU Autoconf 2.67. Invocation command line was
1412514125
14126 CONFIG_FILES = $CONFIG_FILES14126 CONFIG_FILES = $CONFIG_FILES
@@ -14186,7 +14186,7 @@
14186cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=114186cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1
14187ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`"14187ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`"
14188ac_cs_version="\\14188ac_cs_version="\\
14189libappindicator config.status 0.2.9914189libappindicator config.status 0.3.0
14190configured by $0, generated by GNU Autoconf 2.67,14190configured by $0, generated by GNU Autoconf 2.67,
14191 with options \\"\$ac_cs_config\\"14191 with options \\"\$ac_cs_config\\"
1419214192
1419314193
=== modified file 'configure.ac'
--- configure.ac 2011-03-16 18:37:03 +0000
+++ configure.ac 2011-03-23 20:57:29 +0000
@@ -1,11 +1,11 @@
11
2AC_INIT(libappindicator, 0.2.99, ted@canonical.com)2AC_INIT(libappindicator, 0.3.0, ted@canonical.com)
3AC_COPYRIGHT([Copyright 2009, 2010 Canonical])3AC_COPYRIGHT([Copyright 2009, 2010 Canonical])
44
5AC_PREREQ(2.53)5AC_PREREQ(2.53)
66
7AM_CONFIG_HEADER(config.h)7AM_CONFIG_HEADER(config.h)
8AM_INIT_AUTOMAKE(libappindicator, 0.2.99)8AM_INIT_AUTOMAKE(libappindicator, 0.3.0)
99
10AM_MAINTAINER_MODE10AM_MAINTAINER_MODE
1111
1212
=== modified file 'debian/changelog'
--- debian/changelog 2011-03-16 19:52:31 +0000
+++ debian/changelog 2011-03-23 20:57:29 +0000
@@ -1,3 +1,10 @@
1libappindicator (0.3.0-0ubuntu1~ppa1) natty; urgency=low
2
3 * New upstream release.
4 * Don't use GIcon with GtkStatusIcon (LP: #708118)
5
6 -- Ted Gould <ted@ubuntu.com> Wed, 23 Mar 2011 15:50:55 -0500
7
1libappindicator (0.2.99-0ubuntu1) natty; urgency=low8libappindicator (0.2.99-0ubuntu1) natty; urgency=low
29
3 * New upstream release.10 * New upstream release.
411
=== modified file 'docs/reference/libappindicator-docs.sgml'
--- docs/reference/libappindicator-docs.sgml 2011-03-16 18:37:03 +0000
+++ docs/reference/libappindicator-docs.sgml 2011-03-23 20:57:29 +0000
@@ -8,7 +8,7 @@
8 <bookinfo>8 <bookinfo>
9 <title>libappindicator Reference Manual</title>9 <title>libappindicator Reference Manual</title>
10 <releaseinfo>10 <releaseinfo>
11 for libappindicator 0.2.9911 for libappindicator 0.3.0
12 </releaseinfo>12 </releaseinfo>
13 </bookinfo>13 </bookinfo>
1414
1515
=== modified file 'docs/reference/version.xml'
--- docs/reference/version.xml 2011-03-16 18:37:03 +0000
+++ docs/reference/version.xml 2011-03-23 20:57:29 +0000
@@ -1,1 +1,1 @@
10.2.9910.3.0
22
=== modified file 'src/app-indicator.c'
--- src/app-indicator.c 2011-03-16 18:37:03 +0000
+++ src/app-indicator.c 2011-03-23 20:57:29 +0000
@@ -1471,34 +1471,26 @@
1471status_icon_changes (AppIndicator * self, gpointer data)1471status_icon_changes (AppIndicator * self, gpointer data)
1472{1472{
1473 GtkStatusIcon * icon = GTK_STATUS_ICON(data);1473 GtkStatusIcon * icon = GTK_STATUS_ICON(data);
1474 GIcon *themed_icon = NULL;
1475 gchar *longname = NULL;1474 gchar *longname = NULL;
14761475
1477 switch (app_indicator_get_status(self)) {1476 switch (app_indicator_get_status(self)) {
1478 case APP_INDICATOR_STATUS_PASSIVE:1477 case APP_INDICATOR_STATUS_PASSIVE:
1479 longname = append_panel_icon_suffix(app_indicator_get_icon(self));1478 longname = append_panel_icon_suffix(app_indicator_get_icon(self));
1480 themed_icon = g_themed_icon_new_with_default_fallbacks (longname);
1481 gtk_status_icon_set_visible(icon, FALSE);1479 gtk_status_icon_set_visible(icon, FALSE);
1482 gtk_status_icon_set_from_gicon(icon, themed_icon);1480 gtk_status_icon_set_from_icon_name(icon, longname);
1483 break;1481 break;
1484 case APP_INDICATOR_STATUS_ACTIVE:1482 case APP_INDICATOR_STATUS_ACTIVE:
1485 longname = append_panel_icon_suffix(app_indicator_get_icon(self));1483 longname = append_panel_icon_suffix(app_indicator_get_icon(self));
1486 themed_icon = g_themed_icon_new_with_default_fallbacks (longname);1484 gtk_status_icon_set_from_icon_name(icon, longname);
1487 gtk_status_icon_set_from_gicon(icon, themed_icon);
1488 gtk_status_icon_set_visible(icon, TRUE);1485 gtk_status_icon_set_visible(icon, TRUE);
1489 break;1486 break;
1490 case APP_INDICATOR_STATUS_ATTENTION:1487 case APP_INDICATOR_STATUS_ATTENTION:
1491 longname = append_panel_icon_suffix(app_indicator_get_attention_icon(self));1488 longname = append_panel_icon_suffix(app_indicator_get_attention_icon(self));
1492 themed_icon = g_themed_icon_new_with_default_fallbacks (longname);1489 gtk_status_icon_set_from_icon_name(icon, longname);
1493 gtk_status_icon_set_from_gicon(icon, themed_icon);
1494 gtk_status_icon_set_visible(icon, TRUE);1490 gtk_status_icon_set_visible(icon, TRUE);
1495 break;1491 break;
1496 };1492 };
14971493
1498 if (themed_icon) {
1499 g_object_unref (themed_icon);
1500 }
1501
1502 if (longname) {1494 if (longname) {
1503 g_free(longname);1495 g_free(longname);
1504 }1496 }

Subscribers

People subscribed via source and target branches