Merge lp:~indicator-applet-developers/indicator-session/ubuntu into lp:~ubuntu-desktop/indicator-session/ubuntu

Proposed by Ted Gould
Status: Merged
Merged at revision: not available
Proposed branch: lp:~indicator-applet-developers/indicator-session/ubuntu
Merge into: lp:~ubuntu-desktop/indicator-session/ubuntu
Diff against target: 167 lines (+65/-5) (has conflicts)
5 files modified
configure.ac (+1/-1)
debian/changelog (+14/-0)
src/gtk-dialog/gtk-logout-helper.c (+40/-0)
src/session-service.c (+2/-2)
src/users-service-dbus.c (+8/-2)
Text conflict in debian/changelog
To merge this branch: bzr merge lp:~indicator-applet-developers/indicator-session/ubuntu
Reviewer Review Type Date Requested Status
Ken VanDine Pending
Review via email: mp+20159@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Ted Gould (ted) wrote :

0.2.4

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'configure.ac'
--- configure.ac 2010-02-18 15:46:44 +0000
+++ configure.ac 2010-02-25 18:04:20 +0000
@@ -4,7 +4,7 @@
4AC_PREREQ(2.53)4AC_PREREQ(2.53)
55
6AM_CONFIG_HEADER(config.h)6AM_CONFIG_HEADER(config.h)
7AM_INIT_AUTOMAKE(indicator-session, 0.2.3)7AM_INIT_AUTOMAKE(indicator-session, 0.2.4)
88
9AM_MAINTAINER_MODE9AM_MAINTAINER_MODE
1010
1111
=== modified file 'debian/changelog'
--- debian/changelog 2010-02-19 15:45:06 +0000
+++ debian/changelog 2010-02-25 18:04:20 +0000
@@ -1,3 +1,4 @@
1<<<<<<< TREE
1indicator-session (0.2.3-0ubuntu2) lucid; urgency=low2indicator-session (0.2.3-0ubuntu2) lucid; urgency=low
23
3 * debian/patches/fix-session-menu-without-gdm.patch4 * debian/patches/fix-session-menu-without-gdm.patch
@@ -6,6 +7,19 @@
67
7 -- Ken VanDine <ken.vandine@canonical.com> Fri, 19 Feb 2010 09:43:14 -05008 -- Ken VanDine <ken.vandine@canonical.com> Fri, 19 Feb 2010 09:43:14 -0500
89
10=======
11indicator-session (0.2.4-0ubuntu1~ppa1) lucid; urgency=low
12
13 * Upstream release 0.2.4
14 * When we can't shutdown with gnome-session fallback to using
15 ConsoleKit.
16 * Detect when GPM isn't available and don't error out.
17 * Change suspend and hibernate detection property names for
18 adjustment to upower.
19
20 -- Ted Gould <ted@ubuntu.com> Thu, 25 Feb 2010 11:57:41 -0600
21
22>>>>>>> MERGE-SOURCE
9indicator-session (0.2.3-0ubuntu1) lucid; urgency=low23indicator-session (0.2.3-0ubuntu1) lucid; urgency=low
1024
11 * Upstream release 0.2.325 * Upstream release 0.2.3
1226
=== modified file 'src/gtk-dialog/gtk-logout-helper.c'
--- src/gtk-dialog/gtk-logout-helper.c 2009-09-24 17:24:09 +0000
+++ src/gtk-dialog/gtk-logout-helper.c 2010-02-25 18:04:20 +0000
@@ -30,6 +30,44 @@
30#include "gconf-helper.h"30#include "gconf-helper.h"
3131
32static void32static void
33consolekit_fallback (LogoutDialogAction action)
34{
35 DBusGConnection * sbus = dbus_g_bus_get(DBUS_BUS_SYSTEM, NULL);
36 g_return_if_fail(sbus != NULL); /* worst case */
37 DBusGProxy * proxy = dbus_g_proxy_new_for_name(sbus, "org.freedesktop.ConsoleKit",
38 "/org/freedesktop/ConsoleKit/Manager",
39 "org.freedesktop.ConsoleKit.Manager");
40
41 if (proxy == NULL) {
42 g_warning("Unable to get consolekit proxy");
43 return;
44 }
45
46 switch (action) {
47 case LOGOUT_DIALOG_LOGOUT:
48 g_warning("Unable to fallback to ConsoleKit for logout as it's a session issue. We need some sort of session handler.");
49 break;
50 case LOGOUT_DIALOG_SHUTDOWN:
51 dbus_g_proxy_call_no_reply(proxy,
52 "Stop",
53 G_TYPE_INVALID);
54 break;
55 case LOGOUT_DIALOG_RESTART:
56 dbus_g_proxy_call_no_reply(proxy,
57 "Restart",
58 G_TYPE_INVALID);
59 break;
60 default:
61 g_warning("Unknown action");
62 break;
63 }
64
65 g_object_unref(proxy);
66
67 return;
68}
69
70static void
33session_action (LogoutDialogAction action)71session_action (LogoutDialogAction action)
34{72{
35 DBusGConnection * sbus;73 DBusGConnection * sbus;
@@ -50,6 +88,8 @@
50 if (sm_proxy == NULL) {88 if (sm_proxy == NULL) {
51 g_warning("Unable to get DBus proxy to SessionManager interface: %s", error->message);89 g_warning("Unable to get DBus proxy to SessionManager interface: %s", error->message);
52 g_error_free(error);90 g_error_free(error);
91
92 consolekit_fallback(action);
53 return;93 return;
54 } 94 }
55 95
5696
=== modified file 'src/session-service.c'
--- src/session-service.c 2010-02-18 15:36:34 +0000
+++ src/session-service.c 2010-02-25 18:04:20 +0000
@@ -226,7 +226,7 @@
226 G_TYPE_STRING,226 G_TYPE_STRING,
227 UP_INTERFACE,227 UP_INTERFACE,
228 G_TYPE_STRING,228 G_TYPE_STRING,
229 "can-suspend",229 "CanSuspend",
230 G_TYPE_INVALID,230 G_TYPE_INVALID,
231 G_TYPE_VALUE,231 G_TYPE_VALUE,
232 G_TYPE_INVALID);232 G_TYPE_INVALID);
@@ -242,7 +242,7 @@
242 G_TYPE_STRING,242 G_TYPE_STRING,
243 UP_INTERFACE,243 UP_INTERFACE,
244 G_TYPE_STRING,244 G_TYPE_STRING,
245 "can-hibernate",245 "CanHibernate",
246 G_TYPE_INVALID,246 G_TYPE_INVALID,
247 G_TYPE_VALUE,247 G_TYPE_VALUE,
248 G_TYPE_INVALID);248 G_TYPE_INVALID);
249249
=== modified file 'src/users-service-dbus.c'
--- src/users-service-dbus.c 2010-02-09 23:24:23 +0000
+++ src/users-service-dbus.c 2010-02-25 18:04:20 +0000
@@ -1,3 +1,4 @@
1/* -*- Mode: C; indent-tabs-mode: nil; c-basic-offset: 2; tab-width: 2 -*- */
1/*2/*
2 * Copyright 2009 Canonical Ltd.3 * Copyright 2009 Canonical Ltd.
3 *4 *
@@ -183,7 +184,8 @@
183 create_ck_proxy (self);184 create_ck_proxy (self);
184 create_seat_proxy (self);185 create_seat_proxy (self);
185186
186 users_loaded (priv->gdm_proxy, self);187 if (priv->gdm_proxy)
188 users_loaded (priv->gdm_proxy, self);
187}189}
188190
189static void191static void
@@ -214,7 +216,7 @@
214 {216 {
215 if (error != NULL)217 if (error != NULL)
216 {218 {
217 g_error ("Unable to get DisplayManager proxy on system bus: %s", error->message);219 g_warning ("Unable to get DisplayManager proxy on system bus: %s", error->message);
218 g_error_free (error);220 g_error_free (error);
219 }221 }
220222
@@ -679,6 +681,8 @@
679 GError *error = NULL;681 GError *error = NULL;
680 gint count;682 gint count;
681683
684 g_return_if_fail (proxy != NULL);
685
682 service = (UsersServiceDbus *)user_data;686 service = (UsersServiceDbus *)user_data;
683 priv = USERS_SERVICE_DBUS_GET_PRIVATE (service);687 priv = USERS_SERVICE_DBUS_GET_PRIVATE (service);
684688
@@ -859,6 +863,8 @@
859start_new_user_session (UsersServiceDbus *self,863start_new_user_session (UsersServiceDbus *self,
860 UserData *user)864 UserData *user)
861{865{
866 g_return_val_if_fail (IS_USERS_SERVICE_DBUS (self), FALSE);
867
862 UsersServiceDbusPrivate *priv = USERS_SERVICE_DBUS_GET_PRIVATE (self);868 UsersServiceDbusPrivate *priv = USERS_SERVICE_DBUS_GET_PRIVATE (self);
863 GError *error = NULL;869 GError *error = NULL;
864 char *ssid;870 char *ssid;

Subscribers

People subscribed via source and target branches

to all changes: