Merge lp:~indicator-applet-developers/indicator-session/ubuntu into lp:~ubuntu-desktop/indicator-session/ubuntu

Proposed by Ted Gould
Status: Merged
Merged at revision: not available
Proposed branch: lp:~indicator-applet-developers/indicator-session/ubuntu
Merge into: lp:~ubuntu-desktop/indicator-session/ubuntu
Diff against target: 167 lines (+65/-5) (has conflicts)
5 files modified
configure.ac (+1/-1)
debian/changelog (+14/-0)
src/gtk-dialog/gtk-logout-helper.c (+40/-0)
src/session-service.c (+2/-2)
src/users-service-dbus.c (+8/-2)
Text conflict in debian/changelog
To merge this branch: bzr merge lp:~indicator-applet-developers/indicator-session/ubuntu
Reviewer Review Type Date Requested Status
Ken VanDine Pending
Review via email: mp+20159@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Ted Gould (ted) wrote :

0.2.4

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'configure.ac'
2--- configure.ac 2010-02-18 15:46:44 +0000
3+++ configure.ac 2010-02-25 18:04:20 +0000
4@@ -4,7 +4,7 @@
5 AC_PREREQ(2.53)
6
7 AM_CONFIG_HEADER(config.h)
8-AM_INIT_AUTOMAKE(indicator-session, 0.2.3)
9+AM_INIT_AUTOMAKE(indicator-session, 0.2.4)
10
11 AM_MAINTAINER_MODE
12
13
14=== modified file 'debian/changelog'
15--- debian/changelog 2010-02-19 15:45:06 +0000
16+++ debian/changelog 2010-02-25 18:04:20 +0000
17@@ -1,3 +1,4 @@
18+<<<<<<< TREE
19 indicator-session (0.2.3-0ubuntu2) lucid; urgency=low
20
21 * debian/patches/fix-session-menu-without-gdm.patch
22@@ -6,6 +7,19 @@
23
24 -- Ken VanDine <ken.vandine@canonical.com> Fri, 19 Feb 2010 09:43:14 -0500
25
26+=======
27+indicator-session (0.2.4-0ubuntu1~ppa1) lucid; urgency=low
28+
29+ * Upstream release 0.2.4
30+ * When we can't shutdown with gnome-session fallback to using
31+ ConsoleKit.
32+ * Detect when GPM isn't available and don't error out.
33+ * Change suspend and hibernate detection property names for
34+ adjustment to upower.
35+
36+ -- Ted Gould <ted@ubuntu.com> Thu, 25 Feb 2010 11:57:41 -0600
37+
38+>>>>>>> MERGE-SOURCE
39 indicator-session (0.2.3-0ubuntu1) lucid; urgency=low
40
41 * Upstream release 0.2.3
42
43=== modified file 'src/gtk-dialog/gtk-logout-helper.c'
44--- src/gtk-dialog/gtk-logout-helper.c 2009-09-24 17:24:09 +0000
45+++ src/gtk-dialog/gtk-logout-helper.c 2010-02-25 18:04:20 +0000
46@@ -30,6 +30,44 @@
47 #include "gconf-helper.h"
48
49 static void
50+consolekit_fallback (LogoutDialogAction action)
51+{
52+ DBusGConnection * sbus = dbus_g_bus_get(DBUS_BUS_SYSTEM, NULL);
53+ g_return_if_fail(sbus != NULL); /* worst case */
54+ DBusGProxy * proxy = dbus_g_proxy_new_for_name(sbus, "org.freedesktop.ConsoleKit",
55+ "/org/freedesktop/ConsoleKit/Manager",
56+ "org.freedesktop.ConsoleKit.Manager");
57+
58+ if (proxy == NULL) {
59+ g_warning("Unable to get consolekit proxy");
60+ return;
61+ }
62+
63+ switch (action) {
64+ case LOGOUT_DIALOG_LOGOUT:
65+ g_warning("Unable to fallback to ConsoleKit for logout as it's a session issue. We need some sort of session handler.");
66+ break;
67+ case LOGOUT_DIALOG_SHUTDOWN:
68+ dbus_g_proxy_call_no_reply(proxy,
69+ "Stop",
70+ G_TYPE_INVALID);
71+ break;
72+ case LOGOUT_DIALOG_RESTART:
73+ dbus_g_proxy_call_no_reply(proxy,
74+ "Restart",
75+ G_TYPE_INVALID);
76+ break;
77+ default:
78+ g_warning("Unknown action");
79+ break;
80+ }
81+
82+ g_object_unref(proxy);
83+
84+ return;
85+}
86+
87+static void
88 session_action (LogoutDialogAction action)
89 {
90 DBusGConnection * sbus;
91@@ -50,6 +88,8 @@
92 if (sm_proxy == NULL) {
93 g_warning("Unable to get DBus proxy to SessionManager interface: %s", error->message);
94 g_error_free(error);
95+
96+ consolekit_fallback(action);
97 return;
98 }
99
100
101=== modified file 'src/session-service.c'
102--- src/session-service.c 2010-02-18 15:36:34 +0000
103+++ src/session-service.c 2010-02-25 18:04:20 +0000
104@@ -226,7 +226,7 @@
105 G_TYPE_STRING,
106 UP_INTERFACE,
107 G_TYPE_STRING,
108- "can-suspend",
109+ "CanSuspend",
110 G_TYPE_INVALID,
111 G_TYPE_VALUE,
112 G_TYPE_INVALID);
113@@ -242,7 +242,7 @@
114 G_TYPE_STRING,
115 UP_INTERFACE,
116 G_TYPE_STRING,
117- "can-hibernate",
118+ "CanHibernate",
119 G_TYPE_INVALID,
120 G_TYPE_VALUE,
121 G_TYPE_INVALID);
122
123=== modified file 'src/users-service-dbus.c'
124--- src/users-service-dbus.c 2010-02-09 23:24:23 +0000
125+++ src/users-service-dbus.c 2010-02-25 18:04:20 +0000
126@@ -1,3 +1,4 @@
127+/* -*- Mode: C; indent-tabs-mode: nil; c-basic-offset: 2; tab-width: 2 -*- */
128 /*
129 * Copyright 2009 Canonical Ltd.
130 *
131@@ -183,7 +184,8 @@
132 create_ck_proxy (self);
133 create_seat_proxy (self);
134
135- users_loaded (priv->gdm_proxy, self);
136+ if (priv->gdm_proxy)
137+ users_loaded (priv->gdm_proxy, self);
138 }
139
140 static void
141@@ -214,7 +216,7 @@
142 {
143 if (error != NULL)
144 {
145- g_error ("Unable to get DisplayManager proxy on system bus: %s", error->message);
146+ g_warning ("Unable to get DisplayManager proxy on system bus: %s", error->message);
147 g_error_free (error);
148 }
149
150@@ -679,6 +681,8 @@
151 GError *error = NULL;
152 gint count;
153
154+ g_return_if_fail (proxy != NULL);
155+
156 service = (UsersServiceDbus *)user_data;
157 priv = USERS_SERVICE_DBUS_GET_PRIVATE (service);
158
159@@ -859,6 +863,8 @@
160 start_new_user_session (UsersServiceDbus *self,
161 UserData *user)
162 {
163+ g_return_val_if_fail (IS_USERS_SERVICE_DBUS (self), FALSE);
164+
165 UsersServiceDbusPrivate *priv = USERS_SERVICE_DBUS_GET_PRIVATE (self);
166 GError *error = NULL;
167 char *ssid;

Subscribers

People subscribed via source and target branches

to all changes: