Merge lp:~indicator-applet-developers/indicator-applet/ubuntu into lp:~ubuntu-desktop/indicator-applet/ubuntu

Proposed by Ted Gould
Status: Merged
Merged at revision: 273
Proposed branch: lp:~indicator-applet-developers/indicator-applet/ubuntu
Merge into: lp:~ubuntu-desktop/indicator-applet/ubuntu
Diff against target: 259 lines (+107/-9)
8 files modified
configure (+1/-1)
configure.ac (+1/-1)
debian/changelog (+19/-0)
debian/control (+8/-7)
debian/indicator-applet-crashdb.conf (+6/-0)
debian/indicator-applet.install (+2/-0)
debian/source_indicator-applet.py (+43/-0)
src/applet-main.c (+27/-0)
To merge this branch: bzr merge lp:~indicator-applet-developers/indicator-applet/ubuntu
Reviewer Review Type Date Requested Status
Sebastien Bacher Pending
Review via email: mp+29480@code.launchpad.net

Description of the change

0.4.3

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'configure'
--- configure 2010-06-04 16:17:45 +0000
+++ configure 2010-07-08 16:34:39 +0000
@@ -2844,7 +2844,7 @@
28442844
2845# Define the identity of the package.2845# Define the identity of the package.
2846 PACKAGE=indicator-applet2846 PACKAGE=indicator-applet
2847 VERSION=0.4.22847 VERSION=0.4.3
28482848
28492849
2850cat >>confdefs.h <<_ACEOF2850cat >>confdefs.h <<_ACEOF
28512851
=== modified file 'configure.ac'
--- configure.ac 2010-06-04 16:17:45 +0000
+++ configure.ac 2010-07-08 16:34:39 +0000
@@ -4,7 +4,7 @@
4AC_PREREQ(2.53)4AC_PREREQ(2.53)
55
6AM_CONFIG_HEADER(config.h)6AM_CONFIG_HEADER(config.h)
7AM_INIT_AUTOMAKE(indicator-applet, 0.4.2)7AM_INIT_AUTOMAKE(indicator-applet, 0.4.3)
88
9AM_MAINTAINER_MODE9AM_MAINTAINER_MODE
10m4_ifdef([AM_SILENT_RULES],[AM_SILENT_RULES])10m4_ifdef([AM_SILENT_RULES],[AM_SILENT_RULES])
1111
=== modified file 'debian/changelog'
--- debian/changelog 2010-06-23 10:06:29 +0000
+++ debian/changelog 2010-07-08 16:34:39 +0000
@@ -1,3 +1,22 @@
1indicator-applet (0.4.3-0ubuntu1~ppa1) lucid; urgency=low
2
3 * New upstream release.
4 ∘ Fix sensitivity handling (LP: #598524)
5 * debian/source_indicator-applet.py, debian/indicator-applet-crashdb.conf,
6 debian/indicator-applet.install: Adding ability to report bugs
7 with non-Ubuntu packages.
8 * debian/source_indicator-applet.py: Typo in filename
9 * debian/control: Removing indicator-renderer dependencies and
10 making them provides.
11 * debian/control: Removing dependency for indicator-applet-appmenu
12 and indicator-applet-complete on indicator-applet.
13
14 [Mitch Towner]
15 * debian/source_indicator-applet.py
16 - Add apport hook. (LP: #583174)
17
18 -- Ted Gould <ted@ubuntu.com> Thu, 08 Jul 2010 11:29:37 -0500
19
1indicator-applet (0.4.2-0ubuntu3) UNRELEASED; urgency=low20indicator-applet (0.4.2-0ubuntu3) UNRELEASED; urgency=low
221
3 * debian/control: Add alternative dependencies to indicator-renderer, to22 * debian/control: Add alternative dependencies to indicator-renderer, to
423
=== modified file 'debian/control'
--- debian/control 2010-06-23 10:06:29 +0000
+++ debian/control 2010-07-08 16:34:39 +0000
@@ -22,10 +22,11 @@
22Architecture: any22Architecture: any
23Depends: ${shlibs:Depends},23Depends: ${shlibs:Depends},
24 ${misc:Depends},24 ${misc:Depends},
25 gnome-panel | indicator-renderer25 gnome-panel
26Recommends: indicator-messages,26Recommends: indicator-messages,
27 indicator-sound,27 indicator-sound,
28 indicator-application28 indicator-application
29Provides: indicator-renderer
29Description: GNOME panel indicator applet30Description: GNOME panel indicator applet
30 indicator-applet is an applet to display information from31 indicator-applet is an applet to display information from
31 various applications consistently in the GNOME panel.32 various applications consistently in the GNOME panel.
@@ -37,8 +38,8 @@
37Architecture: any38Architecture: any
38Depends: ${shlibs:Depends},39Depends: ${shlibs:Depends},
39 ${misc:Depends},40 ${misc:Depends},
40 gnome-panel | indicator-renderer,41 gnome-panel,
41 indicator-applet (= ${binary:Version}) | indicator-renderer42 indicator-applet (= ${binary:Version})
42Recommends: indicator-session,43Recommends: indicator-session,
43 indicator-me44 indicator-me
44Conflicts: indicator-applet-sus, gdm (<< 2.27.90-0ubuntu1), fast-user-switch-applet45Conflicts: indicator-applet-sus, gdm (<< 2.27.90-0ubuntu1), fast-user-switch-applet
@@ -54,13 +55,13 @@
54Architecture: any55Architecture: any
55Depends: ${shlibs:Depends},56Depends: ${shlibs:Depends},
56 ${misc:Depends},57 ${misc:Depends},
57 gnome-panel | indicator-renderer,58 gnome-panel
58 indicator-applet (= ${binary:Version}) | indicator-renderer
59Recommends: indicator-session,59Recommends: indicator-session,
60 indicator-me,60 indicator-me,
61 indicator-messages,61 indicator-messages,
62 indicator-sound,62 indicator-sound,
63 indicator-application63 indicator-application
64Provides: indicator-renderer
64Description: Clone of the GNOME panel indicator applet65Description: Clone of the GNOME panel indicator applet
65 Indicator-applet is an applet to display information from66 Indicator-applet is an applet to display information from
66 various applications consistently in the GNOME panel.67 various applications consistently in the GNOME panel.
@@ -72,9 +73,9 @@
72Architecture: any73Architecture: any
73Depends: ${shlibs:Depends},74Depends: ${shlibs:Depends},
74 ${misc:Depends},75 ${misc:Depends},
75 gnome-panel | indicator-renderer,76 gnome-panel
76 indicator-applet (= ${binary:Version}) | indicator-renderer
77Recommends: indicator-appmenu77Recommends: indicator-appmenu
78Provides: indicator-renderer
78Description: Clone of the GNOME panel indicator applet79Description: Clone of the GNOME panel indicator applet
79 Indicator-applet is an applet to display information from80 Indicator-applet is an applet to display information from
80 various applications consistently in the GNOME panel.81 various applications consistently in the GNOME panel.
8182
=== added file 'debian/indicator-applet-crashdb.conf'
--- debian/indicator-applet-crashdb.conf 1970-01-01 00:00:00 +0000
+++ debian/indicator-applet-crashdb.conf 2010-07-08 16:34:39 +0000
@@ -0,0 +1,6 @@
1
2indicator_applet = {
3 'impl': 'launchpad',
4 'project': 'indicator-applet',
5 'bug_pattern_base': None,
6}
07
=== modified file 'debian/indicator-applet.install'
--- debian/indicator-applet.install 2009-08-18 19:15:12 +0000
+++ debian/indicator-applet.install 2010-07-08 16:34:39 +0000
@@ -1,3 +1,5 @@
1debian/tmp/usr/lib/bonobo/servers/GNOME_IndicatorApplet.server1debian/tmp/usr/lib/bonobo/servers/GNOME_IndicatorApplet.server
2debian/tmp/usr/lib/indicator-applet/indicator-applet2debian/tmp/usr/lib/indicator-applet/indicator-applet
3debian/tmp/usr/share/icons3debian/tmp/usr/share/icons
4debian/source_indicator-applet.py usr/share/apport/package-hooks
5debian/indicator-applet-crashdb.conf /etc/apport/crashdb.conf.d/
46
=== added file 'debian/source_indicator-applet.py'
--- debian/source_indicator-applet.py 1970-01-01 00:00:00 +0000
+++ debian/source_indicator-applet.py 2010-07-08 16:34:39 +0000
@@ -0,0 +1,43 @@
1import os.path
2from apport.hookutils import *
3from xdg.BaseDirectory import xdg_cache_home
4
5APPLET_LOG = os.path.join(xdg_cache_home, 'indicator-applet.log')
6APPLET_SESSION_LOG = os.path.join(xdg_cache_home, 'indicator-applet-session.log')
7COMPLETE_LOG = os.path.join(xdg_cache_home, 'indicator-applet-complete.log')
8APPMENU_LOG = os.path.join(xdg_cache_home, 'indicator-applet-appmenu.log')
9
10def add_info(report, ui):
11 if not apport.packaging.is_distro_package(report['Package'].split()[0]):
12 report['ThirdParty'] = 'True'
13 report['CrashDB'] = 'indicator_applet'
14
15 response = ui.choice("How would you describe the issue?", ["None of the indicator applets are working correctly", "The sound applet is not working correctly", "The Social Networking Menu is not working correctly", "The login/logout applet is not working correctly", "The network applet is not working correctly", "The date/time applet in not working correctly", "The application testing applet in not working correctly", "The all-in-one (complete) applet is not working correctly", "Another applet is not working correctly"], False)
16 try:
17 if response == None: # user cancelled
18 raise StopIteration
19 if response[0] == 0: # an issue with indicator-applet
20 report.add_package_info("indicator-applet")
21 if response[0] == 1: # the issue is with indicator-sound
22 report.add_package_info("indicator-sound")
23 if response[0] == 2: # the issue is with indicator-me
24 report.add_package_info("indicator-me")
25 if response[0] == 3: # the issue is with indicator-session
26 report.add_package_info("indicator-session")
27 if response[0] == 4: # the issue is with indicator-network in UNE
28 report.add_package_info("indicator-network")
29 if response[0] == 5: # the issue is with indicator-datetime in "unity"
30 report.add_package_info("indicator-datetime")
31 if response[0] == 6: # the issue is with indicator-applet-appmenu
32 report.add_package_info("indicator-applet-appmenu")
33 if response[0] == 7: # the issue is with indicator-applet-complete
34 report.add_package_info("indicator-applet-complete")
35 if response[0] == 8: # the issue is with indicator-application
36 report.add_package_info("indicator-application")
37 except:
38 print 'Unfortunately, that package is not installed. Please refer to https://wiki.ubuntu.com/Bugs/FindRightPackage'
39
40 attach_file_if_exists(report, APPLET_LOG, 'indicator-applet.log')
41 attach_file_if_exists(report, APPLET_SESSION_LOG, 'indicator-applet-session.log')
42 attach_file_if_exists(report, COMPLETE_LOG, 'indicator-applet-complete.log')
43 attach_file_if_exists(report, APPMENU_LOG, 'indicator-applet-appmenu.log')
044
=== modified file 'src/applet-main.c'
--- src/applet-main.c 2010-06-04 16:17:45 +0000
+++ src/applet-main.c 2010-07-08 16:34:39 +0000
@@ -206,10 +206,21 @@
206}206}
207207
208static void208static void
209sensitive_cb (GObject * obj, GParamSpec * pspec, gpointer user_data)
210{
211 g_return_if_fail(GTK_IS_WIDGET(obj));
212 g_return_if_fail(GTK_IS_WIDGET(user_data));
213
214 gtk_widget_set_sensitive(GTK_WIDGET(user_data), gtk_widget_get_sensitive(GTK_WIDGET(obj)));
215 return;
216}
217
218static void
209entry_added (IndicatorObject * io, IndicatorObjectEntry * entry, GtkWidget * menubar)219entry_added (IndicatorObject * io, IndicatorObjectEntry * entry, GtkWidget * menubar)
210{220{
211 g_debug("Signal: Entry Added");221 g_debug("Signal: Entry Added");
212 gboolean something_visible = FALSE;222 gboolean something_visible = FALSE;
223 gboolean something_sensitive = FALSE;
213224
214 GtkWidget * menuitem = gtk_menu_item_new();225 GtkWidget * menuitem = gtk_menu_item_new();
215 GtkWidget * box = (packdirection == GTK_PACK_DIRECTION_LTR) ?226 GtkWidget * box = (packdirection == GTK_PACK_DIRECTION_LTR) ?
@@ -224,8 +235,14 @@
224 something_visible = TRUE;235 something_visible = TRUE;
225 }236 }
226237
238 if (gtk_widget_get_sensitive(GTK_WIDGET(entry->image))) {
239 something_sensitive = TRUE;
240 }
241
227 g_signal_connect(G_OBJECT(entry->image), "show", G_CALLBACK(something_shown), menuitem);242 g_signal_connect(G_OBJECT(entry->image), "show", G_CALLBACK(something_shown), menuitem);
228 g_signal_connect(G_OBJECT(entry->image), "hide", G_CALLBACK(something_hidden), menuitem);243 g_signal_connect(G_OBJECT(entry->image), "hide", G_CALLBACK(something_hidden), menuitem);
244
245 g_signal_connect(G_OBJECT(entry->image), "notify::sensitive", G_CALLBACK(sensitive_cb), menuitem);
229 }246 }
230 if (entry->label != NULL) {247 if (entry->label != NULL) {
231 switch(packdirection) {248 switch(packdirection) {
@@ -241,12 +258,19 @@
241 break;258 break;
242 } 259 }
243 gtk_box_pack_start(GTK_BOX(box), GTK_WIDGET(entry->label), FALSE, FALSE, 0);260 gtk_box_pack_start(GTK_BOX(box), GTK_WIDGET(entry->label), FALSE, FALSE, 0);
261
244 if (gtk_widget_get_visible(GTK_WIDGET(entry->label))) {262 if (gtk_widget_get_visible(GTK_WIDGET(entry->label))) {
245 something_visible = TRUE;263 something_visible = TRUE;
246 }264 }
247265
266 if (gtk_widget_get_sensitive(GTK_WIDGET(entry->label))) {
267 something_sensitive = TRUE;
268 }
269
248 g_signal_connect(G_OBJECT(entry->label), "show", G_CALLBACK(something_shown), menuitem);270 g_signal_connect(G_OBJECT(entry->label), "show", G_CALLBACK(something_shown), menuitem);
249 g_signal_connect(G_OBJECT(entry->label), "hide", G_CALLBACK(something_hidden), menuitem);271 g_signal_connect(G_OBJECT(entry->label), "hide", G_CALLBACK(something_hidden), menuitem);
272
273 g_signal_connect(G_OBJECT(entry->label), "notify::sensitive", G_CALLBACK(sensitive_cb), menuitem);
250 }274 }
251 gtk_container_add(GTK_CONTAINER(menuitem), box);275 gtk_container_add(GTK_CONTAINER(menuitem), box);
252 gtk_widget_show(box);276 gtk_widget_show(box);
@@ -268,6 +292,7 @@
268 if (something_visible) {292 if (something_visible) {
269 gtk_widget_show(menuitem);293 gtk_widget_show(menuitem);
270 }294 }
295 gtk_widget_set_sensitive(menuitem, something_sensitive);
271296
272 g_object_set_data(G_OBJECT(menuitem), MENU_DATA_INDICATOR_ENTRY, entry);297 g_object_set_data(G_OBJECT(menuitem), MENU_DATA_INDICATOR_ENTRY, entry);
273 g_object_set_data(G_OBJECT(menuitem), MENU_DATA_INDICATOR_OBJECT, io);298 g_object_set_data(G_OBJECT(menuitem), MENU_DATA_INDICATOR_OBJECT, io);
@@ -288,10 +313,12 @@
288 if (entry->label != NULL) {313 if (entry->label != NULL) {
289 g_signal_handlers_disconnect_by_func(G_OBJECT(entry->label), G_CALLBACK(something_shown), widget);314 g_signal_handlers_disconnect_by_func(G_OBJECT(entry->label), G_CALLBACK(something_shown), widget);
290 g_signal_handlers_disconnect_by_func(G_OBJECT(entry->label), G_CALLBACK(something_hidden), widget);315 g_signal_handlers_disconnect_by_func(G_OBJECT(entry->label), G_CALLBACK(something_hidden), widget);
316 g_signal_handlers_disconnect_by_func(G_OBJECT(entry->label), G_CALLBACK(sensitive_cb), widget);
291 }317 }
292 if (entry->image != NULL) {318 if (entry->image != NULL) {
293 g_signal_handlers_disconnect_by_func(G_OBJECT(entry->image), G_CALLBACK(something_shown), widget);319 g_signal_handlers_disconnect_by_func(G_OBJECT(entry->image), G_CALLBACK(something_shown), widget);
294 g_signal_handlers_disconnect_by_func(G_OBJECT(entry->image), G_CALLBACK(something_hidden), widget);320 g_signal_handlers_disconnect_by_func(G_OBJECT(entry->image), G_CALLBACK(something_hidden), widget);
321 g_signal_handlers_disconnect_by_func(G_OBJECT(entry->image), G_CALLBACK(sensitive_cb), widget);
295 }322 }
296323
297 gtk_widget_destroy(widget);324 gtk_widget_destroy(widget);

Subscribers

People subscribed via source and target branches