Merge lp:~indicator-applet-developers/indicator-applet/ubuntu into lp:~ubuntu-desktop/indicator-applet/ubuntu

Proposed by Ted Gould
Status: Merged
Merged at revision: 273
Proposed branch: lp:~indicator-applet-developers/indicator-applet/ubuntu
Merge into: lp:~ubuntu-desktop/indicator-applet/ubuntu
Diff against target: 259 lines (+107/-9)
8 files modified
configure (+1/-1)
configure.ac (+1/-1)
debian/changelog (+19/-0)
debian/control (+8/-7)
debian/indicator-applet-crashdb.conf (+6/-0)
debian/indicator-applet.install (+2/-0)
debian/source_indicator-applet.py (+43/-0)
src/applet-main.c (+27/-0)
To merge this branch: bzr merge lp:~indicator-applet-developers/indicator-applet/ubuntu
Reviewer Review Type Date Requested Status
Sebastien Bacher Pending
Review via email: mp+29480@code.launchpad.net

Description of the change

0.4.3

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'configure'
2--- configure 2010-06-04 16:17:45 +0000
3+++ configure 2010-07-08 16:34:39 +0000
4@@ -2844,7 +2844,7 @@
5
6 # Define the identity of the package.
7 PACKAGE=indicator-applet
8- VERSION=0.4.2
9+ VERSION=0.4.3
10
11
12 cat >>confdefs.h <<_ACEOF
13
14=== modified file 'configure.ac'
15--- configure.ac 2010-06-04 16:17:45 +0000
16+++ configure.ac 2010-07-08 16:34:39 +0000
17@@ -4,7 +4,7 @@
18 AC_PREREQ(2.53)
19
20 AM_CONFIG_HEADER(config.h)
21-AM_INIT_AUTOMAKE(indicator-applet, 0.4.2)
22+AM_INIT_AUTOMAKE(indicator-applet, 0.4.3)
23
24 AM_MAINTAINER_MODE
25 m4_ifdef([AM_SILENT_RULES],[AM_SILENT_RULES])
26
27=== modified file 'debian/changelog'
28--- debian/changelog 2010-06-23 10:06:29 +0000
29+++ debian/changelog 2010-07-08 16:34:39 +0000
30@@ -1,3 +1,22 @@
31+indicator-applet (0.4.3-0ubuntu1~ppa1) lucid; urgency=low
32+
33+ * New upstream release.
34+ ∘ Fix sensitivity handling (LP: #598524)
35+ * debian/source_indicator-applet.py, debian/indicator-applet-crashdb.conf,
36+ debian/indicator-applet.install: Adding ability to report bugs
37+ with non-Ubuntu packages.
38+ * debian/source_indicator-applet.py: Typo in filename
39+ * debian/control: Removing indicator-renderer dependencies and
40+ making them provides.
41+ * debian/control: Removing dependency for indicator-applet-appmenu
42+ and indicator-applet-complete on indicator-applet.
43+
44+ [Mitch Towner]
45+ * debian/source_indicator-applet.py
46+ - Add apport hook. (LP: #583174)
47+
48+ -- Ted Gould <ted@ubuntu.com> Thu, 08 Jul 2010 11:29:37 -0500
49+
50 indicator-applet (0.4.2-0ubuntu3) UNRELEASED; urgency=low
51
52 * debian/control: Add alternative dependencies to indicator-renderer, to
53
54=== modified file 'debian/control'
55--- debian/control 2010-06-23 10:06:29 +0000
56+++ debian/control 2010-07-08 16:34:39 +0000
57@@ -22,10 +22,11 @@
58 Architecture: any
59 Depends: ${shlibs:Depends},
60 ${misc:Depends},
61- gnome-panel | indicator-renderer
62+ gnome-panel
63 Recommends: indicator-messages,
64 indicator-sound,
65 indicator-application
66+Provides: indicator-renderer
67 Description: GNOME panel indicator applet
68 indicator-applet is an applet to display information from
69 various applications consistently in the GNOME panel.
70@@ -37,8 +38,8 @@
71 Architecture: any
72 Depends: ${shlibs:Depends},
73 ${misc:Depends},
74- gnome-panel | indicator-renderer,
75- indicator-applet (= ${binary:Version}) | indicator-renderer
76+ gnome-panel,
77+ indicator-applet (= ${binary:Version})
78 Recommends: indicator-session,
79 indicator-me
80 Conflicts: indicator-applet-sus, gdm (<< 2.27.90-0ubuntu1), fast-user-switch-applet
81@@ -54,13 +55,13 @@
82 Architecture: any
83 Depends: ${shlibs:Depends},
84 ${misc:Depends},
85- gnome-panel | indicator-renderer,
86- indicator-applet (= ${binary:Version}) | indicator-renderer
87+ gnome-panel
88 Recommends: indicator-session,
89 indicator-me,
90 indicator-messages,
91 indicator-sound,
92 indicator-application
93+Provides: indicator-renderer
94 Description: Clone of the GNOME panel indicator applet
95 Indicator-applet is an applet to display information from
96 various applications consistently in the GNOME panel.
97@@ -72,9 +73,9 @@
98 Architecture: any
99 Depends: ${shlibs:Depends},
100 ${misc:Depends},
101- gnome-panel | indicator-renderer,
102- indicator-applet (= ${binary:Version}) | indicator-renderer
103+ gnome-panel
104 Recommends: indicator-appmenu
105+Provides: indicator-renderer
106 Description: Clone of the GNOME panel indicator applet
107 Indicator-applet is an applet to display information from
108 various applications consistently in the GNOME panel.
109
110=== added file 'debian/indicator-applet-crashdb.conf'
111--- debian/indicator-applet-crashdb.conf 1970-01-01 00:00:00 +0000
112+++ debian/indicator-applet-crashdb.conf 2010-07-08 16:34:39 +0000
113@@ -0,0 +1,6 @@
114+
115+indicator_applet = {
116+ 'impl': 'launchpad',
117+ 'project': 'indicator-applet',
118+ 'bug_pattern_base': None,
119+}
120
121=== modified file 'debian/indicator-applet.install'
122--- debian/indicator-applet.install 2009-08-18 19:15:12 +0000
123+++ debian/indicator-applet.install 2010-07-08 16:34:39 +0000
124@@ -1,3 +1,5 @@
125 debian/tmp/usr/lib/bonobo/servers/GNOME_IndicatorApplet.server
126 debian/tmp/usr/lib/indicator-applet/indicator-applet
127 debian/tmp/usr/share/icons
128+debian/source_indicator-applet.py usr/share/apport/package-hooks
129+debian/indicator-applet-crashdb.conf /etc/apport/crashdb.conf.d/
130
131=== added file 'debian/source_indicator-applet.py'
132--- debian/source_indicator-applet.py 1970-01-01 00:00:00 +0000
133+++ debian/source_indicator-applet.py 2010-07-08 16:34:39 +0000
134@@ -0,0 +1,43 @@
135+import os.path
136+from apport.hookutils import *
137+from xdg.BaseDirectory import xdg_cache_home
138+
139+APPLET_LOG = os.path.join(xdg_cache_home, 'indicator-applet.log')
140+APPLET_SESSION_LOG = os.path.join(xdg_cache_home, 'indicator-applet-session.log')
141+COMPLETE_LOG = os.path.join(xdg_cache_home, 'indicator-applet-complete.log')
142+APPMENU_LOG = os.path.join(xdg_cache_home, 'indicator-applet-appmenu.log')
143+
144+def add_info(report, ui):
145+ if not apport.packaging.is_distro_package(report['Package'].split()[0]):
146+ report['ThirdParty'] = 'True'
147+ report['CrashDB'] = 'indicator_applet'
148+
149+ response = ui.choice("How would you describe the issue?", ["None of the indicator applets are working correctly", "The sound applet is not working correctly", "The Social Networking Menu is not working correctly", "The login/logout applet is not working correctly", "The network applet is not working correctly", "The date/time applet in not working correctly", "The application testing applet in not working correctly", "The all-in-one (complete) applet is not working correctly", "Another applet is not working correctly"], False)
150+ try:
151+ if response == None: # user cancelled
152+ raise StopIteration
153+ if response[0] == 0: # an issue with indicator-applet
154+ report.add_package_info("indicator-applet")
155+ if response[0] == 1: # the issue is with indicator-sound
156+ report.add_package_info("indicator-sound")
157+ if response[0] == 2: # the issue is with indicator-me
158+ report.add_package_info("indicator-me")
159+ if response[0] == 3: # the issue is with indicator-session
160+ report.add_package_info("indicator-session")
161+ if response[0] == 4: # the issue is with indicator-network in UNE
162+ report.add_package_info("indicator-network")
163+ if response[0] == 5: # the issue is with indicator-datetime in "unity"
164+ report.add_package_info("indicator-datetime")
165+ if response[0] == 6: # the issue is with indicator-applet-appmenu
166+ report.add_package_info("indicator-applet-appmenu")
167+ if response[0] == 7: # the issue is with indicator-applet-complete
168+ report.add_package_info("indicator-applet-complete")
169+ if response[0] == 8: # the issue is with indicator-application
170+ report.add_package_info("indicator-application")
171+ except:
172+ print 'Unfortunately, that package is not installed. Please refer to https://wiki.ubuntu.com/Bugs/FindRightPackage'
173+
174+ attach_file_if_exists(report, APPLET_LOG, 'indicator-applet.log')
175+ attach_file_if_exists(report, APPLET_SESSION_LOG, 'indicator-applet-session.log')
176+ attach_file_if_exists(report, COMPLETE_LOG, 'indicator-applet-complete.log')
177+ attach_file_if_exists(report, APPMENU_LOG, 'indicator-applet-appmenu.log')
178
179=== modified file 'src/applet-main.c'
180--- src/applet-main.c 2010-06-04 16:17:45 +0000
181+++ src/applet-main.c 2010-07-08 16:34:39 +0000
182@@ -206,10 +206,21 @@
183 }
184
185 static void
186+sensitive_cb (GObject * obj, GParamSpec * pspec, gpointer user_data)
187+{
188+ g_return_if_fail(GTK_IS_WIDGET(obj));
189+ g_return_if_fail(GTK_IS_WIDGET(user_data));
190+
191+ gtk_widget_set_sensitive(GTK_WIDGET(user_data), gtk_widget_get_sensitive(GTK_WIDGET(obj)));
192+ return;
193+}
194+
195+static void
196 entry_added (IndicatorObject * io, IndicatorObjectEntry * entry, GtkWidget * menubar)
197 {
198 g_debug("Signal: Entry Added");
199 gboolean something_visible = FALSE;
200+ gboolean something_sensitive = FALSE;
201
202 GtkWidget * menuitem = gtk_menu_item_new();
203 GtkWidget * box = (packdirection == GTK_PACK_DIRECTION_LTR) ?
204@@ -224,8 +235,14 @@
205 something_visible = TRUE;
206 }
207
208+ if (gtk_widget_get_sensitive(GTK_WIDGET(entry->image))) {
209+ something_sensitive = TRUE;
210+ }
211+
212 g_signal_connect(G_OBJECT(entry->image), "show", G_CALLBACK(something_shown), menuitem);
213 g_signal_connect(G_OBJECT(entry->image), "hide", G_CALLBACK(something_hidden), menuitem);
214+
215+ g_signal_connect(G_OBJECT(entry->image), "notify::sensitive", G_CALLBACK(sensitive_cb), menuitem);
216 }
217 if (entry->label != NULL) {
218 switch(packdirection) {
219@@ -241,12 +258,19 @@
220 break;
221 }
222 gtk_box_pack_start(GTK_BOX(box), GTK_WIDGET(entry->label), FALSE, FALSE, 0);
223+
224 if (gtk_widget_get_visible(GTK_WIDGET(entry->label))) {
225 something_visible = TRUE;
226 }
227
228+ if (gtk_widget_get_sensitive(GTK_WIDGET(entry->label))) {
229+ something_sensitive = TRUE;
230+ }
231+
232 g_signal_connect(G_OBJECT(entry->label), "show", G_CALLBACK(something_shown), menuitem);
233 g_signal_connect(G_OBJECT(entry->label), "hide", G_CALLBACK(something_hidden), menuitem);
234+
235+ g_signal_connect(G_OBJECT(entry->label), "notify::sensitive", G_CALLBACK(sensitive_cb), menuitem);
236 }
237 gtk_container_add(GTK_CONTAINER(menuitem), box);
238 gtk_widget_show(box);
239@@ -268,6 +292,7 @@
240 if (something_visible) {
241 gtk_widget_show(menuitem);
242 }
243+ gtk_widget_set_sensitive(menuitem, something_sensitive);
244
245 g_object_set_data(G_OBJECT(menuitem), MENU_DATA_INDICATOR_ENTRY, entry);
246 g_object_set_data(G_OBJECT(menuitem), MENU_DATA_INDICATOR_OBJECT, io);
247@@ -288,10 +313,12 @@
248 if (entry->label != NULL) {
249 g_signal_handlers_disconnect_by_func(G_OBJECT(entry->label), G_CALLBACK(something_shown), widget);
250 g_signal_handlers_disconnect_by_func(G_OBJECT(entry->label), G_CALLBACK(something_hidden), widget);
251+ g_signal_handlers_disconnect_by_func(G_OBJECT(entry->label), G_CALLBACK(sensitive_cb), widget);
252 }
253 if (entry->image != NULL) {
254 g_signal_handlers_disconnect_by_func(G_OBJECT(entry->image), G_CALLBACK(something_shown), widget);
255 g_signal_handlers_disconnect_by_func(G_OBJECT(entry->image), G_CALLBACK(something_hidden), widget);
256+ g_signal_handlers_disconnect_by_func(G_OBJECT(entry->image), G_CALLBACK(sensitive_cb), widget);
257 }
258
259 gtk_widget_destroy(widget);

Subscribers

People subscribed via source and target branches