Code review comment for lp:~indicator-applet-developers/evolution-indicator/ignore-inactive-accounts

Revision history for this message
Ted Gould (ted) wrote :

On Wed, 2009-09-16 at 11:00 +0000, Neil J. Patel wrote:
> Fixes two issues to do with showing accounts in the menu:
>
> 1. If the user has made an account inactive, make sure it doesn't show up, and
> 2. If an account doesn't have a configured way to receive email (i.e. its just there as an smtp server), then don't show it in the menu as it'll never receive mail. This matches evolutions behaviour.

Looks good, excited about the feature!

  review approve

review: Approve

« Back to merge proposal