Code review comment for lp:~ilidrissi.amine/update-manager/group-of-patches

Revision history for this message
Michael Vogt (mvo) wrote :

Thanks for the branch. Unfortunately the change to look for changelogs inside launchpad is not suitable. The reason is that launchpad.net generates the pages dynamically out of a database. Hitting them from potentially hundrets of thousands of users is dangerous. But the good news is that the launchpad soyuz team is working on providing the changelogs in the PPA pool/ directory. This way its a static file served by apache and we can use that performance risks for launchpad.

The other fix looks very good and I'm happy to take it.

« Back to merge proposal