Code review comment for lp:~ilidrissi.amine/gesturetest/621600-no-args
Revision history for this message
| Mohamed Amine Ilidrissi (ilidrissi.amine) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
> I still disagree as I think this may lead to sloppy coding. For example,
> adding 0 as a window parameter to gesturetest to listen on all windows has
> already led to an improper implementation of gestures in Unity. Unity
> currently listens for window specific gestures on all windows, including root,
> and uses the focus point to choose the correct window for manipulation. This
> is plain wrong, and only occurred because the gesturetest code had a path for
> doing this (gesturetest code was basically copied and pasted into Unity). Thus
> far, 1/1 gesture projects have used gesturetest and subsequently been written
> improperly :).
>
> That said, I'm apparently in the minority and this isn't a huge deal. I'll
> merge this change in when I have a chance.
Your opinion still counts, though. You shouldn't approve this just because everyone else is okay with it. That said, thanks :)