Merge ~ilasc/launchpad:add-repack-stats-api into launchpad:master

[Ioana Lasc]

Add API to see repack stats for one repo

I think the quickest and less computationally expensive way for us to have some visibility into repack data for a repository at the moment is an API.

The proposed endpoint might not be optimal but I figured proposing an attempt via code might be the easiest way for us to start discussing / refining a reasonable approach to this.

[Colin Watson (cjwatson)]

We could do this, but the attributes in question are just simple ints/datetimes and they aren't secret. Any reason not to just export them as read-only attributes on IGitRepository?

review: Needs Information

1ee7e3c... by Ioana Lasc on 2021-03-19

Expose repack data as read-only

[Ioana Lasc (ilasc)]

Agreed they could just be exposed on the interface as read-only attributes, done.

[Colin Watson (cjwatson)]

Thanks for the update! A few minor nits, but otherwise LGTM - go ahead and land this once you've fixed these.

review: Approve

5b56401... by Ioana Lasc on 2021-03-23

Make repack stats not required on interface

diff --git a/lib/lp/code/interfaces/gitrepository.py b/lib/lp/code/interfaces/gitrepository.py
index 365f082..5374fb7 100644
--- a/lib/lp/code/interfaces/gitrepository.py
+++ b/lib/lp/code/interfaces/gitrepository.py
@@ -216,6 +216,23 @@ class IGitRepositoryView(IHasRecipes):
     shortened_path = Attribute(
         "The shortest reasonable version of the path to this repository.")
 
+    pack_count = exported(Int(
+        title=_("Pack count"), readonly=True, required=False,
+        description=_("The number of packs for this repository.")))
+
+    loose_object_count = exported(Int(
+        title=_("Loose object count"), readonly=True, required=False,
+        description=_("The number of loose objects for this repository.")))
+
+    date_last_repacked = exported(Datetime(
+        title=_("Date last repacked"), readonly=True, required=False,
+        description=_("The date that this repository was last repacked.")))
+
+    date_last_scanned = exported(Datetime(
+        title=_("Date last scanned"), readonly=True, required=False,
+        description=_("The date when pack statistics were last updated "
+                      "for this repository.")))
+
     def getClonedFrom():
         """Returns from which repository the given repo is a clone from."""
 
diff --git a/lib/lp/code/model/tests/test_gitrepository.py b/lib/lp/code/model/tests/test_gitrepository.py
index bdf636b..6cec839 100644
--- a/lib/lp/code/model/tests/test_gitrepository.py
+++ b/lib/lp/code/model/tests/test_gitrepository.py
@@ -3900,6 +3900,39 @@ class TestGitRepositoryWebservice(TestCaseWithFactory):
             hosting_fixture.repackRepository.calls)
         self.assertEqual(1, hosting_fixture.repackRepository.call_count)
 
+    def test_repack_data(self):
+        owner_db = self.factory.makePerson(name="person")
+        project_db = self.factory.makeProduct(name="project")
+        repository_db = self.factory.makeGitRepository(
+            owner=owner_db, target=project_db, name="repository")
+        webservice = webservice_for_person(
+            repository_db.owner, permission=OAuthPermission.READ_PUBLIC)
+        webservice.default_api_version = "devel"
+        with person_logged_in(ANONYMOUS):
+            repository_url = api_url(repository_db)
+        repository = webservice.get(repository_url).jsonBody()
+        self.assertThat(repository, ContainsDict({
+            'loose_object_count': Is(None),
+            'pack_count': Is(None),
+            'date_last_repacked': Is(None),
+            'date_last_scanned': Is(None),
+            }))
+
+        repository_db = removeSecurityProxy(repository_db)
+        repository_db.loose_object_count = 45
+        repository_db.pack_count = 523
+        repository_db.date_last_repacked = UTC_NOW
+        repository_db.date_last_scanned = UTC_NOW
+
+        repository = webservice.get(repository_url).jsonBody()
+
+        self.assertThat(repository, ContainsDict({
+            'loose_object_count': Equals(45),
+            'pack_count': Equals(523),
+            'date_last_repacked': Equals(UTC_NOW),
+            'date_last_scanned': Equals(UTC_NOW),
+            }))
+
     def test_urls(self):
         owner_db = self.factory.makePerson(name="person")
         project_db = self.factory.makeProduct(name="project")