Code review comment for ~ilasc/launchpad:person-oci-registry-credentials-edit

Revision history for this message
Tom Wardill (twom) wrote :

Some comments inline, mostly indentation and such.

The use of removeSecurityProxy in both the tests and the especially the view context seems a bit strange to me, is it required?
I can't see why you don't have the right privileges to update the objects without it. That said, my understanding of how all that works is a bit hazy!

review: Needs Information

« Back to merge proposal