Code review comment for lp:~ijk/gtimelog/nutmeg

Revision history for this message
Marius Gedminas (mgedmin) wrote :

Actually, wait a second:

        xdg = os.environ.get('XDG_CONFIG_HOME')
        if xdg is not None:
            return os.path.expanduser(xdg)
        else:
            return os.path.expanduser("~/.config/gtimelog")

so if I set XDG_CONFIG_HOME=~/.config, then gtimelog will use ~/.config/gtimelogrc?

Shouldn't that be

        xdg = os.environ.get('XDG_CONFIG_HOME')
        if xdg is not None:
            return os.path.join(os.path.expanduser(xdg), 'gtimelog')
        else:
            return os.path.expanduser("~/.config/gtimelog")

and likewise for the data dir?

review: Needs Fixing

« Back to merge proposal