Code review comment for lp:~ijk/gtimelog/nutmeg

Revision history for this message
Marius Gedminas (mgedmin) wrote :

This:

+ subject = 'Weekly report for {} (week {:0>2})'.format(who, week)

means a UnicodeEncodeError if who is a unicode string with non-ASCII characters.

Although testing reveals that currently `who` is a byte string, which causes bug 1117109, so this doesn't make anything worse.

(It also drops support for Python 2.6 or older, which is probably fine. We'll see if anyone complains about that.)

There are some minor PEP-8 transgressions that I'll fix up after merging.

(Ick, launchpad's review UI sucks. Why haven't I moved to github already?)

review: Approve

« Back to merge proposal