Merge ~igor-brovtsin/maas:no-route-found-test-fix into maas:master

[Igor Brovtsin]

Updated IP for "no route" test in "provisioningserver.utils.tests.test_network:TestGetSourceAddress"

Previously, this test failed in some environments where there was a route to `127.0.0.0` (see https://bugs.launchpad.net/maas/+bug/1989949). This MP replaces the IP to `255.255.255.255` that works better in that context.

[MAAS Lander (maas-lander)]

UNIT TESTS
-b no-route-found-test-fix lp:~igor-brovtsin/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 8490dbfc3102cd3942354931e53bd43e5ad0f339

review: Approve

[Adam Collard (adam-collard)]

+1 with suggestions

review: Approve

bf6e3d8... by Igor Brovtsin on 2022-09-16

Changed assertThat(Is(None)) to assertIsNone in test_returns_none_if_no_route_found

[MAAS Lander (maas-lander)]

UNIT TESTS
-b no-route-found-test-fix lp:~igor-brovtsin/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: bf6e3d80eb237aeeed48ecae3e2a46973c07ec4e

review: Approve

[Anton Troyanov (troyanov)]

Congrats on the 1st landed MP :)

diff --git a/src/provisioningserver/utils/tests/test_network.py b/src/provisioningserver/utils/tests/test_network.py
index 433db7d..3d82a40 100644
--- a/src/provisioningserver/utils/tests/test_network.py
+++ b/src/provisioningserver/utils/tests/test_network.py
@@ -2471,7 +2471,7 @@ class TestGetSourceAddress(MAASTestCase):
         self.assertThat(get_source_address("::1"), Equals("::1"))
 
     def test_returns_none_if_no_route_found(self):
-        self.assertThat(get_source_address("127.0.0.0"), Is(None))
+        self.assertIsNone(get_source_address("255.255.255.255"))
 
     def test_returns_appropriate_address_for_global_ip(self):
         self.assertThat(get_source_address("8.8.8.8"), Not(Is(None)))