Merge lp:~ignacio-nin/sysbench/0.5-bug1262178 into lp:sysbench
Proposed by
Ignacio Nin
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Alexey Kopytov | ||||
Approved revision: | 120 | ||||
Merged at revision: | 120 | ||||
Proposed branch: | lp:~ignacio-nin/sysbench/0.5-bug1262178 | ||||
Merge into: | lp:sysbench | ||||
Diff against target: |
15 lines (+2/-2) 1 file modified
sysbench/tests/fileio/sb_fileio.c (+2/-2) |
||||
To merge this branch: | bzr merge lp:~ignacio-nin/sysbench/0.5-bug1262178 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alexey Kopytov | Approve | ||
Review via email: mp+199448@code.launchpad.net |
Description of the change
Fix for bug #1262178
To test:
$ sysbench --test=fileio --file-num=1 --file-
$ sysbench --test=fileio --file-num=1 --file-
To post a comment you must log in.
According to http:// msdn.microsoft. com/en- us/library/ windows/ desktop/ aa366563% 28v=vs. 85%29.aspx the return value of FlushViewOfFile differs from the UNIX paragidm, i.e. zero on error and a nonzero value on success. So the Windows codepath should be
return !FlushViewOfFil e(...);
I will fix it in the merge.