Merge lp:~ignacio-nin/percona-server/5.5-debian-init-script into lp:percona-server/5.5
Status: | Work in progress |
---|---|
Proposed branch: | lp:~ignacio-nin/percona-server/5.5-debian-init-script |
Merge into: | lp:percona-server/5.5 |
Diff against target: |
652 lines (+16/-193) 4 files modified
build/debian/percona-server-server-5.5.mysql.init (+0/-184) build/debian/percona-server-server-5.5.postinst (+1/-1) build/debian/percona-server-server-5.5.postrm (+7/-3) build/debian/percona-server-server-5.5.preinst (+8/-5) |
To merge this branch: | bzr merge lp:~ignacio-nin/percona-server/5.5-debian-init-script |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alexey Kopytov (community) | Needs Information | ||
Ignacio Nin (community) | Needs Resubmitting | ||
Review via email: mp+186948@code.launchpad.net |
Description of the change
New debian init script from the upstream package
Unmerged revisions
- 560. By Ignacio Nin
-
Replace the debian init script with the script provided by source
The debian init script had some issues when it came to detecting the
server had been started -- it had a hardcoded 15 seconds wait (although
this could be overridden by my.cnf) and in order to detect a running
server it tried to login to it.This came with issues when a) the startup time exceeded 15 seconds, which
is something that can easily happen with datasets of hundreds of gigs,
and b) if there was no user available for the init script to use, or the
user had been misconfigured somehow. Of course, these two possibilites
were true too often.Replace the script with the one provided by MySQL, which uses a PID-file
based detection mechanism to check whether the server has been started or
stopped.Given that the two init scripts share no common history (the previous one
came from the debian distribution), bzr rm and bzr add it to avoid
pointless conflicts. Merge this with the same fix for 5.1, and share the
file id with the corresponding file in that branch. - 559. By Ignacio Nin
-
Unify the file-id's from the pre and post scripts for dpkg.
Null merge of this change in 5.1. Also introduce some local changes for
help with the merges.
- Comment for rev. 559 says file-id changes have been null-merged to 5.5, but I see that build/debian/ percona- server- server- 5.5.mysql. init still changes its file-id. Is that intentional?
- are there any specific bugs that this change is supposed to solve? If so, they should be referenced in comments/--fixes.
- the following change smells like a charset conversion issue:
658 - cp /usr/share/ percona- server- common/ internal- use-only/ `echo $file | sed 's°/°_°g'` $file percona- server- common/ internal- use-only/ `echo $file | sed 's�/�_�g'` $file
659 + cp /usr/share/