Code review comment for lp:~ignacio-nin/percona-server/5.5-debian-init-script

Ignacio Nin (ignacio-nin) wrote :

> - Comment for rev. 559 says file-id changes have been null-merged to 5.5, but
> I see that build/debian/percona-server-server-5.5.mysql.init still changes its
> file-id. Is that intentional?

Yes, the file-id for this file is created new in 560, since it's a completely new file. 559 is indeed a null-merge.

>
> - are there any specific bugs that this change is supposed to solve? If so,
> they should be referenced in comments/--fixes.

Resubmitting with the same comments as for the 5.1 branch

>
> - the following change smells like a charset conversion issue:
>
> 658 - cp /usr/share/percona-server-common/internal-use-only/`echo $file |
> sed 's°/°_°g'` $file
> 659 + cp /usr/share/percona-server-common/internal-use-only/`echo $file |
> sed 's�/�_�g'` $file

Fix't-

review: Resubmit

« Back to merge proposal