Code review comment for lp:~ignacio-nin/percona-server/5.1-binary-out-of-source

Revision history for this message
Ignacio Nin (ignacio-nin) wrote :

> Using "bzr export" means it will be impossible to use build-binary.sh when the
> source directory is not a bazaar branch, e.g. has been unpacked from a source
> tarball.

Indeed, however these scripts convenience scripts meant for using with the full branch when we're building the packages (or a sample), not for the exported source. For an exported source a standard configure/make procedure should be used (and only the Percona-Server/ subdirectory).

Please notice that bzr(1) and a .bzr/ directory was already a requirement for the script since we use bzr revno for adding the revision number to the binary name.

« Back to merge proposal