Merge lp:~ibressler/pyqtgraph/devel into lp:pyqtgraph/dev
Proposed by
Ingo Breßler
Status: | Needs review |
---|---|
Proposed branch: | lp:~ibressler/pyqtgraph/devel |
Merge into: | lp:pyqtgraph/dev |
Diff against target: |
13 lines (+1/-2) 1 file modified
graphicsItems/PlotCurveItem.py (+1/-2) |
To merge this branch: | bzr merge lp:~ibressler/pyqtgraph/devel |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
lcampagn | code | Disapprove | |
Review via email:
|
Description of the change
ScatterPlotItem(x, y) printed data (x,y) transposed due to argument swapping
To post a comment you must log in.
Unmerged revisions
- 102. By Ingo Breßler
-
fixed wrong argument passing order
ScatterPlotItem(x, y) printed data transposed previously
- 101. By Luke Campagnola
-
minor plotting example update
- 100. By Luke Campagnola
-
bugfix
Thanks, Ingo! Turns out there were a few related issues in that file, so my
fix is a bit different from yours (but should work the same for you).
Luke
On Mon, Apr 23, 2012 at 08:40, Ingo Breßler <email address hidden> wrote:
> Ingo Breßler has proposed merging lp:~ibressler/pyqtgraph/devel into /code.launchpad .net/~ibressler /pyqtgraph/ devel/+ merge/103092 /code.launchpad .net/~ibressler /pyqtgraph/ devel/+ merge/103092 PlotCurveItem. py' PlotCurveItem. py 2012-04-21 19:55:27 +0000 PlotCurveItem. py 2012-04-23 12:39:27 +0000 ode(QtGui. QGraphicsItem. DeviceCoordinat eCache)
> lp:~luke-campagnola/pyqtgraph/dev.
>
> Requested reviews:
> lcampagn (luke-campagnola)
>
> For more details, see:
> https:/
>
> ScatterPlotItem(x, y) printed data (x,y) transposed due to argument
> swapping
> --
> https:/
> You are requested to review the proposed merge of
> lp:~ibressler/pyqtgraph/devel into lp:~luke-campagnola/pyqtgraph/dev.
>
> === modified file 'graphicsItems/
> --- graphicsItems/
> +++ graphicsItems/
> @@ -63,8 +63,7 @@
> self.exportOpts = False
> self.antialias = False
>
> - if y is not None:
> - self.updateData(y, x)
> + self.updateData(x, y)
>
> ## this is disastrous for performance.
> #self.setCacheM
>
>
>