Code review comment for lp:~ibmcharmers/charms/trusty/ibm-db2/trunk

Revision history for this message
Suchitra Venugopal (suchvenu) wrote :

 I just removed the 2 functions you added for missing license and curl config , to check whether everything else is working fine.

1. DB2 gets installed but shows the state as

ibm-db2:
    charm: local:trusty/ibm-db2-15
    exposed: false
    service-status:
      current: maintenance
      message: Installing binutils,curl,pwgen,tar
      since: 14 Jul 2016 09:37:15+05:30
    units:
      ibm-db2/14:
        workload-status:
          current: maintenance
          message: Installing binutils,curl,pwgen,tar
          since: 14 Jul 2016 09:37:15+05:30
        agent-status:
          current: idle
          since: 14 Jul 2016 10:07:49+05:30
          version: 1.25.5.1
        agent-state: started
        agent-version: 1.25.5.1
        machine: "49"
        public-address: 10.0.3.141

The status history shows like this :

charm@islrpbeixv665:~/charms/trusty$ juju status-history ibm-db2/14 -n 1000
TIME TYPE STATUS MESSAGE
14 Jul 2016 09:21:59+05:30 workload unknown Waiting for agent initialization to finish
14 Jul 2016 09:21:59+05:30 agent allocating
14 Jul 2016 09:24:51+05:30 workload maintenance installing charm software
14 Jul 2016 09:24:52+05:30 agent executing running install hook
14 Jul 2016 09:26:24+05:30 workload maintenance ibm-base: fetching resource(s)
14 Jul 2016 09:34:38+05:30 workload active ibm-base: curl resource(s) fetched
14 Jul 2016 09:34:39+05:30 workload maintenance Installing pre requisites for IBM DB2
14 Jul 2016 09:34:51+05:30 workload maintenance Installed pre requisites for IBM DB2
14 Jul 2016 09:34:51+05:30 workload maintenance Updating apt cache
14 Jul 2016 09:35:25+05:30 workload maintenance Installing IBM DB2
14 Jul 2016 09:37:15+05:30 workload active IBM DB2 Installed
14 Jul 2016 09:37:15+05:30 workload maintenance Installing binutils,curl,pwgen,tar
14 Jul 2016 09:37:15+05:30 workload maintenance Installing binutils,curl,pwgen,tar
14 Jul 2016 09:37:20+05:30 agent executing running leader-elected hook
14 Jul 2016 09:37:23+05:30 agent executing running config-changed hook
14 Jul 2016 09:37:26+05:30 agent executing running start hook
14 Jul 2016 09:37:28+05:30 agent executing running update-status hook
14 Jul 2016 09:37:33+05:30 agent idle
14 Jul 2016 09:42:31+05:30 agent executing running update-status hook
14 Jul 2016 09:42:36+05:30 agent idle
14 Jul 2016 09:47:34+05:30 agent executing running update-status hook
14 Jul 2016 09:47:39+05:30 agent idle
14 Jul 2016 09:52:37+05:30 agent executing running update-status hook
14 Jul 2016 09:52:42+05:30 agent idle
14 Jul 2016 09:57:40+05:30 agent executing running update-status hook
14 Jul 2016 09:57:44+05:30 agent idle
14 Jul 2016 10:02:42+05:30 agent executing running update-status hook
14 Jul 2016 10:02:46+05:30 agent idle
14 Jul 2016 10:02:46+05:30 agent idle

 I also tried to give juju set ibm-db2 license_accepted="True" alone, after the package is downloaded and looks like this time it goes fine. The changes you did for the reactive code should not affect this change in behaviour. Does the change in layer.yaml only affecting this ?

charm@islrpbeixv665:~/charms/trusty/ibm-db2$ juju status-history ibm-db2/18 -n 1000
TIME TYPE STATUS MESSAGE
14 Jul 2016 11:55:24+05:30 workload unknown Waiting for agent initialization to finish
14 Jul 2016 11:55:24+05:30 agent allocating
14 Jul 2016 11:57:21+05:30 workload maintenance installing charm software
14 Jul 2016 11:57:21+05:30 agent executing running install hook
14 Jul 2016 11:58:17+05:30 workload maintenance Updating apt cache
14 Jul 2016 11:58:28+05:30 workload maintenance Installing pre requisites for IBM DB2
14 Jul 2016 11:58:40+05:30 workload maintenance Installed pre requisites for IBM DB2
14 Jul 2016 11:58:41+05:30 workload maintenance ibm-base: fetching resource(s)
14 Jul 2016 12:15:16+05:30 workload active ibm-base: curl resource(s) fetched
14 Jul 2016 12:15:17+05:30 workload maintenance Installing binutils,curl,pwgen,tar
14 Jul 2016 12:15:20+05:30 agent executing running leader-elected hook
14 Jul 2016 12:15:22+05:30 workload blocked license_accepted must be set
14 Jul 2016 12:15:24+05:30 agent executing running config-changed hook
14 Jul 2016 12:15:26+05:30 workload blocked license_accepted must be set
14 Jul 2016 12:15:27+05:30 agent executing running start hook
14 Jul 2016 12:15:30+05:30 workload blocked license_accepted must be set
14 Jul 2016 12:15:31+05:30 agent executing running update-status hook
14 Jul 2016 12:15:33+05:30 workload blocked license_accepted must be set
14 Jul 2016 12:15:36+05:30 agent idle
14 Jul 2016 12:16:41+05:30 agent executing running config-changed hook

« Back to merge proposal