Code review comment for lp:~ibmcharmers/charms/trusty/ibm-db2/trunk

Hi Suchitra, I made quite a few tweaks to the layered source:

http://bazaar.launchpad.net/~ibmcharmers/charms/trusty/layer-ibm-db2/trunk/revision/20?compare_revid=15

Some are cosmetic, others are bash-ism tweaks (like comparing strings with == and integers with -eq). The most significant, however, is in the password handling of db2 users.

I didn't realize before that the db2inst1, dasusr1, db2fenc1, and the users for related units all had default passwords. This isn't acceptable for applications providing network services, so I updated this charm to use the 'pwgen' utility to create random passwords for these users.

Have a look at the above diff, which is available for deployment at:

cs:~ibmcharmers/trusty/ibm-db2-39

If you're ok with these changes, we can (finally) promulgate v39 :)

Thanks!
-Kevin