> Overall this looks good. I encountered a couple of small rough edges from the
> ibm-base layer, which can be addressed there. But I did notice that the ibm-
> db2.client.sshconfigured state is not set per-consumer; once any consumer
> sends SSH keys, all consumers will assume that keys have been sent, and once
> any one consumer departs, all consumers will be blocked even if they
> previously sent SSH keys. I don't know if that was intended, but it seems
> like that state should be set by the interface layer instead, such as in the
> dismiss() method.
Hi Cory,
I have done the changes as per your suggestions. Please review once and let me know.
> Overall this looks good. I encountered a couple of small rough edges from the sshconfigured state is not set per-consumer; once any consumer
> ibm-base layer, which can be addressed there. But I did notice that the ibm-
> db2.client.
> sends SSH keys, all consumers will assume that keys have been sent, and once
> any one consumer departs, all consumers will be blocked even if they
> previously sent SSH keys. I don't know if that was intended, but it seems
> like that state should be set by the interface layer instead, such as in the
> dismiss() method.
Hi Cory,
I have done the changes as per your suggestions. Please review once and let me know.
Thanks,
Suchitra