Code review comment for lp:~ibid-dev/ibid/factoid-544493

Revision history for this message
Stefano Rivera (stefanor) wrote :

> .all()[number:]
> .all()[number]

Those alls are required for "I only know foo things", please add a comment explaining that.

> x.like(y, escape='\\')

You can't do that with MySQL. See the equivalent in get_factoid.

The new search code is too complicated, I think.
Does search really need to be implemented as two pass? Why not just skip $arg matching in search and translate $arg into _ instead?

review: Needs Fixing

« Back to merge proposal