Code review comment for lp:~ibelieve/ubuntu-filemanager-app/improved-toolbar

Revision history for this message
Michael Spencer (ibelieve) wrote :

> Nice work!
>
> A couple of things that I've noticed:
>
> - The toolbar icons are highly pixelated. Nothing that your branch can do
> about it, as it might be due to bug 1184569. Perhaps it might be worth
> shipping local copies of .png images until that bug is fixed?

I've added local copies for the 4 icons in the toolbar.

> - The properties popup for folders seem to always return "Unknown" for
> "Created:" and "Modified:"

Clicking on a folder and choosing Properties should work. If you mean clicking Actions and then Properties, that is because it's using new features from the model that Carlos just added, so it won't show up until the plugin gets updated. (Same with the current folder being writable or not).

« Back to merge proposal