Code review comment for lp:~ian-liu88/unity-lens-applications/fix-for-bug-734762

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Excellent Ian! Working as advertised and the code looks good :)

I wondering if you want to do the final polish on that, I mean:
Type Alt + F2:
- enter ~foo/bar
-> the directories matching in instance: /home/foo/bar* as we have with direct typing in /home/foo/bar*

For that, I would:
- move subst_tilde to src/utils.vala
- in update_search for runner.vala, in addition to if (search_string.has_prefix ("/")), add a or "~" in search_string and call the subst_tilde function to introspect in it.

Anyway, just tell me if you want to finish this or not, I can do it, you've already made most of the hard work and thanks for this! :)

« Back to merge proposal