Code review comment for lp:~ian-clatworthy/bzr/faster-tags
Revision history for this message
| Ian Clatworthy (ian-clatworthy) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
Martin Pool wrote:
> Review: Needs Information
> It's helpful when we're reporting on bzr progress to put an indicative performance number in the news like "5-10x faster". (Especially when it's as good as you've done here.) I realize it's not spads-approved and ymmv etc.
>
Sure. The numbers can be quite variable but I'm happy to say something
like "up to 70X faster" as a tweak. I can do the same for the other
things I've put into the one NEWS item as well.
> I might be missing something but it looks like in the previous code the dict 'tags' was indexed by tag name but here it's indexed by the enumeration integer
tags is a list of tuples, not a dict. The code and tests are all fine. I
checked all the tests (for tags) passed before I submitted the patch (as
I do for 95% of patches I send in).
Ian C.