Code review comment for lp:~ian-clatworthy/bzr/faster-log.old

Martin Pool (mbp) wrote :

2009/5/29 Ian Clatworthy <email address hidden>:
> So checking our existing test coverage, we have log tests for unicode messages and unicode diff content but not for unicode committer/authors. Do I need to add those before landing this? My preference is to put that task on my list but not do it immediately, given all I'm doing is replacing "multiple outf.write()" calls with "collecting lines & calling outf.write() once". I can't see how that can break things or how it reduces test coverage?

It's down to you, but I think those tests will be fairly easy to
write, and it's probably better not to have it hanging around.

--
Martin <http://launchpad.net/~mbp/>

« Back to merge proposal