Code review comment for lp:~ian-clatworthy/bzr/faster-log.old

Ian Clatworthy (ian-clatworthy) wrote :

So checking our existing test coverage, we have log tests for unicode messages and unicode diff content but not for unicode committer/authors. Do I need to add those before landing this? My preference is to put that task on my list but not do it immediately, given all I'm doing is replacing "multiple outf.write()" calls with "collecting lines & calling outf.write() once". I can't see how that can break things or how it reduces test coverage?

Otherwise, your suggested tweaks are fine by me.

« Back to merge proposal