Bazaar

Code review comment for lp:~ian-clatworthy/bzr/eol-none-bug

  1. eol-none-bug
  2. Merge into trunk-old
Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ian Clatworthy wrote:
> Ian Clatworthy has proposed merging lp:~ian-clatworthy/bzr/eol-none-bug into lp:bzr.
>
> Requested reviews:
> bzr-core (bzr-core)
>
> This is another fix required to make content filtering and rule handling work. We recently introduced some stricter checking around the value of the eol setting but that broke other uses of rules, e.g. keywords and plugins using them.
>
> A small fix and some tests are provided. I'd like this in 1.16.
>

+ prefs = (('eol',None),)
this should be
+ prefs = (('eol', None),)

+ prefs = (('foo',None),('bar', 'v1'))

As should this.

But otherwise

  review approve

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkovwRQACgkQJdeBCYSNAAPO2wCeJhmXwbZnuu/FCh/R9qnMACit
vq4AoLgK9mNRY63b7atKfZGXC8loDTZ9
=+vHV
-----END PGP SIGNATURE-----

review: Approve

« Back to merge proposal