Code review comment for lp:~ian-clatworthy/bzr/doc-site-per-language

Revision history for this message
Ian Clatworthy (ian-clatworthy) wrote :

Martin Pool wrote:
> It looks like this also gets rid of the duplication of the version numbers, which is great.

It does.

> If this still adds a hard dependency on sphinx then I'd still be concerned about the impact on packaging; please don't land this til that's addressed or I'm convinced otherwise.

Sure. Some things to consider:

1. All the distros packaging Bazaar are also packaging python and it's
docs are in Sphinx too. So whatever solution there are using for
packaging the python docs can be reused for Bazaar in theory.

2. The simple solution is for packagers to grab the html.tar.bz2
generated by us from doc.bazaar-vcs.org. There's no compelling reason
they must generate the doc themselves, unless they are applying
downstream patches which impact the doc (extremely unlikely I'd hope).

3. IMO, it would be far more risky to land this post rc2 than pre rc2.
The time between rc2 and 2.0 is the very time when packaging issues
ought to be detected and addressed.

Ian C.

« Back to merge proposal