Code review comment for lp:~ian-clatworthy/bzr-builder/minor-code-cleanups

Revision history for this message
Ian Clatworthy (ian-clatworthy) wrote :

> 8 +# The default distribution used by get_changelog_entry()
> 9 +DEFAULT_UBUNTU_DISTRIBUTION = "jaunty"
>
> Doing this makes it clear that this should be "lucid" now.

Fixed.

> 38 +def run_command(command, msg, error_msg):
>
> 69 + _run_command(command,
>
> 86 + _run_command(command,
>
> 103 + _run_command(command,
>
> These should match shouldn't they?

Fixed.

> 53 + raise errors.BzrCommandError("%s: %s" % (output, error_msg))
>
> Aren't output and error_msg the wrong way round?

Oops. Fixed now.

« Back to merge proposal