Code review comment for lp:~ialastairhunter/nunitlite/categoryfilter

Revision history for this message
Charlie Poole (charlie.poole) wrote :

Just a few procedural comments before I actually review this...

1. It's generally best to use a separate branch per feature. This merge request actually fixes two unrelated bugs. Having them together means we have to either accept or postpone both of them, whereas it's very common to have different fixes follow different life cycles as new ideas come up, questions get asked, etc.

2. Something to do with end of line settings is messing us up here, making it look as if you have deleted and re-inserted very large selections of code. We should try to avoid this in the future. When the diff makes it clear what has changed, it's often possible to just look at the code to do the review. In this case, I'll have to merge your changes into a working directory and use some tools that will give a more meaningful diff. That takes longer.

With our current plan to do a release on the weekend, I'll just work with this merge as it is. The above is just info for the future. I'll be back later with the actual review.

« Back to merge proposal