Code review comment for lp:~iahmad/dialer-app/smart-dialing-test

Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

> Thanks for writing this test.
> This MR uses the user's addressbook and also assumes it is empty. I don't
> think that is a good idea, because we are required to run tests on our own
> devices and we are not going to be emptying the addressbook for that.
>
> My suggestion would be to use the memory backend for the addressbook, there
> are two MRs being done to prepare the dialer-app to support that:
> https://code.launchpad.net/~renatofilho/address-book-app/contact-list-default-
> model/+merge/204103
> https://code.launchpad.net/~boiko/dialer-
> app/contacts_memory_backend/+merge/206521
>
> Can you please revisit this test after those MRs are merged?

Actually, I was talking to Renato about that, and we both think it would be a much better idea to have the address-book-service to use the folks dummy backend (same effect as using the memory backend on the apps themselves), but with the advantage that we can write inter-app tests (like creating a contact from a call log entry, etc).
This would probably require that the autopilot tests are executed in a separate dbus session, not sure if this would be possible.

« Back to merge proposal