Code review comment for lp:~hyuchia/screenshot-tool/fix-1668074

Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

If save_file gets passed an invalid (non-existent) directory (which could happen when using the Plank context menu method) then the save fails, so it would be best to do an existence check here as well as in the SaveDialog. You can just pass "" as the folder_dir parameter when called with from_command == true, instead of looking up the setting twice.

« Back to merge proposal